don't warn about a missing change-id in CI

[lolbinarycat]

fixes #130352

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[onur-ozkan]

Why this doesn't work already?

rust/src/ci/run.sh

Lines 50 to 53 in e7386b3

	# suppress change-tracker warnings on CI
	if [ "$CI" != "" ]; then
	RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set change-id=99999999"
	fi

Directly ignoring the change tracker at the bootstrap level could have negative effects for downstream CIs.

[workingjubilee]

as a downstream CI: I am also ignoring this in my CI because I do not care about all the notifications because they are never relevant to me.

[workingjubilee]

if something happens that is important, the CI will probably break. until then, the 9 million tiny changes that only matter to interactive users are not very relevant. it doesn't matter if my eyes glaze over when I see the message or if I actively silence it: the same effect of "I ain't readin' all that" takes place.

[onur-ozkan]

Directly ignoring the change tracker at the bootstrap level could have negative effects for downstream CIs.

Update on this: I initially thought this PR was ignoring the change messages, but it’s actually just skipping the help message for the missing field. That makes sense. I have just created an alternative PR that skips the help message for everyone by default unless running in verbose mode.

[workingjubilee]

thank you! personally happy to see whatever variation on this people like better land.

[albertlarsan68]

LGTM, sorry for the delay!

[albertlarsan68]

@bors r+ rollup

[bors]

📌 Commit 32f01b2 has been approved by albertlarsan68

It is now in the queue for this repository.

[onur-ozkan]

LGTM, sorry for the delay!

Did you check #130368? If so, I will close that one.

[albertlarsan68]

I think that those are quite orthogonal