Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add repr/transparent test for aarch64 #130466

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

davidtwco
Copy link
Member

Fixes #74396.

Moves transparent-struct-ptr.rs to transparent-byval-struct-ptr.rs and then adds a new transparent-opaque-ptr.rs for aarch64.

Moves `transparent-struct-ptr.rs` to `transparent-byval-struct-ptr.rs`
and then adds a new `transparent-opaque-ptr.rs` for aarch64.
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems reasonable.

tests/codegen/repr/transparent-opaque-ptr.rs Show resolved Hide resolved
@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 17, 2024
@jieyouxu
Copy link
Member

Please r=me after PR CI is green. The remark is not blocking.

@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 9a33074 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2024
@workingjubilee
Copy link
Member

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Sep 17, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 17, 2024

📌 Commit 9a33074 has been approved by jieyouxu

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130466 (tests: add repr/transparent test for aarch64)
 - rust-lang#130468 (Make sure that def id <=> lang item map is bidirectional)
 - rust-lang#130499 (Add myself to the libs review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b21581d into rust-lang:master Sep 18, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
Rollup merge of rust-lang#130466 - davidtwco:aarch64-transparent-test, r=jieyouxu

tests: add repr/transparent test for aarch64

Fixes rust-lang#74396.

Moves `transparent-struct-ptr.rs` to `transparent-byval-struct-ptr.rs` and then adds a new `transparent-opaque-ptr.rs` for aarch64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add suitable tests for aarch64 for repr-transparent-aggregates-1.rs
7 participants