Rollup of 5 pull requests #130572

matthiaskrgr · 2024-09-19T18:37:10Z

Successful merges:

Improve documentation for <integer>::from_str_radix #128001 (Improve documentation for ::from_str_radix)
[Clippy] Get rid of most std match_def_path usage, swap to diagnostic items. #130553 ([Clippy] Get rid of most std match_def_path usage, swap to diagnostic items.)
pal::unsupported::process::ExitCode: use an u8 instead of a bool #130554 (pal::unsupported::process::ExitCode: use an u8 instead of a bool)
Mark the link_cfg feature as internal #130556 (Mark the link_cfg feature as internal)
Support 128-bit atomics on s390x #130558 (Support 128-bit atomics on s390x)

r? @ghost
@rustbot modify labels: rollup

Two improvements to the documentation: - Document `-` as a valid character for signed integer destinations - Make the documentation even more clear that extra whitespace and non-digit characters is invalid. Many other languages, e.g. c++, are very permissive in string to integer routines and simply try to consume as much as they can, ignoring the rest. This is trying to make the transition for developers who are used to the conversion semantics in these languages a bit easier.

…of path

…f paths

…stead of paths

…ead of path

…ostic items instead of paths

…ad of path

… of paths

…f path

… path

…f path

…m instead of path

…tead of path

…f paths

Improve documentation for <integer>::from_str_radix Two improvements to the documentation: - Document `-` as a valid character for signed integer destinations - Make the documentation even more clear that extra whitespace and non-digit characters is invalid. Many other languages, e.g. c++, are very permissive in string to integer routines and simply try to consume as much as they can, ignoring the rest. This is trying to make the transition for developers who are used to the conversion semantics in these languages a bit easier.

…ompiler-errors [Clippy] Get rid of most `std` `match_def_path` usage, swap to diagnostic items. Part of rust-lang/rust-clippy#5393. This was going to remove all `std` paths, but `SeekFrom` has issues being cleanly replaced with a diagnostic item as the paths are for variants, which currently cannot be diagnostic items. This also, as a last step, categories the paths to help with future path removals.

…atrieb `pal::unsupported::process::ExitCode`: use an `u8` instead of a `bool` `ExitCode` should “represents the status code the current process can return to its parent under normal termination”, but is currently represented as a `bool` on unsupported platforms, making the `impl From<u8> for ExitCode` lossy. Fixes rust-lang#130532. History: [IRLO thread](https://internals.rust-lang.org/t/mini-pre-rfc-redesigning-process-exitstatus/5426) (`ExitCode` as a `main` return), rust-lang#48618 (initial impl), rust-lang#93445 (`From<u8>` impl).

Mark the `link_cfg` feature as internal This PR marks the `link_cfg` feature as internal because it's a perme-unstable feature, only used by `core`/`std`and `unwind`.

Support 128-bit atomics on s390x Since LLVM 18 (llvm/llvm-project@c568927), 128-bit atomics are fully supported on s390x. And the current minimum external LLVM version is now 18 (rust-lang#130487). s390x 128-bit atomic instructions (lpq,stpq,cdsg) has been present since [the First Edition of the Principles of Operation](https://publibfp.dhe.ibm.com/epubs/pdf/dz9zr000.pdf). (LLVM's minimal supported architecture level [is z10 (the Eighth Edition of the PoP)](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZProcessors.td#L16-L17).) cc rust-lang#99069 r? `@cuviper`

matthiaskrgr · 2024-09-19T18:37:23Z

@bors r+ rollup=never p=5

bors · 2024-09-19T18:37:26Z

📌 Commit f715815 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-09-19T18:40:34Z

⌛ Testing commit f715815 with merge 506f22b...

bors · 2024-09-19T21:05:00Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 506f22b to master...

rust-timer · 2024-09-19T21:06:26Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#128001	Improve documentation for ::from_str_radix	`88c0cb706e97f8a8b9e9b7a69fedfa4ac7c4741c` (link)
#130553	[Clippy] Get rid of most `std` `match_def_path` usage, swap…	`0b28e760bd0fab1ffd6b571966827e1a0f96d8b2` (link)
#130554	`pal::unsupported::process::ExitCode`: use an `u8` instead …	`52585792d5fcf9db40748dc287302928743dbd6f` (link)
#130556	Mark the `link_cfg` feature as internal	`e8c95992a159df9692c579dd424be9754aea80c6` (link)
#130558	Support 128-bit atomics on s390x	`05c799eecfb98b188656196174b7544bb469fee7` (link)

previous master: 749f80ab05

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-09-19T22:21:54Z

Finished benchmarking commit (506f22b): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.2%, secondary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	2
Regressions ❌ (secondary)	4.1%	[2.3%, 5.9%]	2
Improvements ✅ (primary)	-1.7%	[-2.3%, -1.0%]	8
Improvements ✅ (secondary)	-1.6%	[-2.5%, -0.8%]	2
All ❌✅ (primary)	-1.2%	[-2.3%, 0.9%]	10

Cycles

Results (secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.206s -> 768.807s (-0.05%)
Artifact size: 341.23 MiB -> 341.34 MiB (0.03%)

Krappa322 and others added 29 commits August 31, 2024 14:23

[Clippy] Swap map_entry to use diagnostic items instead of paths

a786be5

[Clippy] Swap lines_filter_map_ok to use a diagnostic item instead …

3ebff28

…of path

Support 128-bit atomics on s390x

078b067

[Clippy] Swap option_as_ref_deref to use diagnostic items instead o…

5e47168

…f paths

[Clippy] Swap float_equality_without_abs to use diagnostic items in…

c891082

…stead of paths

[Clippy] Swap redundant_clone to use diagnostic items instead of paths

afe7907

[Clippy] Swap manual_main_separator_str to use diagnostic item inst…

037b978

…ead of path

[Clippy] Swap single_char_add_str/format_push_string to use diagn…

28f4c82

…ostic items instead of paths

[Clippy] Swap VecArgs::hir to use diagnostic items instead of paths

846ae57

[Clippy] Swap repeat_vec_with_capacity to use diagnostic item inste…

15240a9

…ad of path

[Clippy] Swap manual_while_let_some to use diagnostic items instead…

25da0e2

… of paths

[Clippy] Swap filter_map_bool_then to use diagnostic item instead o…

5b55270

…f path

[Clippy] Swap waker_clone_wake to use diagnostic item instead of path

372f68b

[Clippy] Swap instant_subtraction to use diagnostic item instead of…

1890620

… path

[Clippy] Swap unnecessary_to_owned to use diagnostic item instead o…

89532c0

…f path

[Clippy] Swap manual_strip to use diagnostic items instead of paths

5f42ae1

[Clippy] Swap unnecessary_owned_empty_strings to use diagnostic ite…

5f85f73

…m instead of path

[Clippy] Swap non_octal_unix_permissions to use diagnostic item ins…

43b8e04

…tead of path

[Clippy] Swap iter_over_hash_type to use diagnostic items instead o…

364e552

…f paths

[Clippy] Swap open_options to use diagnostic items instead of paths

b2eebee

Categorise paths in clippy_utils::paths

13d5732

pal::unsupported::process::ExitCode: use an u8 instead of a bool

dc628c8

Make link_cfg internal because it's in perme-unstable

b67485e

Rollup merge of rust-lang#130556 - Urgau:link_cfg_internal, r=jieyouxu

9f0d32c

Mark the `link_cfg` feature as internal This PR marks the `link_cfg` feature as internal because it's a perme-unstable feature, only used by `core`/`std`and `unwind`.

rustbot added the O-unix Operating system: Unix-like label Sep 19, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 19, 2024

bors merged commit 506f22b into rust-lang:master Sep 19, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 19, 2024

This was referenced Sep 19, 2024

Add #[track_caller] to allocating methods of Vec & VecDeque #126557

Merged

liballoc: introduce String, Vec const-slicing #128399

Merged

Clippy subtree update #129991

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #130572

Rollup of 5 pull requests #130572

matthiaskrgr commented Sep 19, 2024

matthiaskrgr commented Sep 19, 2024

bors commented Sep 19, 2024

bors commented Sep 19, 2024

bors commented Sep 19, 2024

rust-timer commented Sep 19, 2024

rust-timer commented Sep 19, 2024

Rollup of 5 pull requests #130572

Rollup of 5 pull requests #130572

Conversation

matthiaskrgr commented Sep 19, 2024

matthiaskrgr commented Sep 19, 2024

bors commented Sep 19, 2024

bors commented Sep 19, 2024

bors commented Sep 19, 2024

rust-timer commented Sep 19, 2024

rust-timer commented Sep 19, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size