-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unstable cfg target(...)
compact feature
#130780
base: master
Are you sure you want to change the base?
Conversation
Wasn’t this helping to remove some use cases for build scripts? |
The part that was supposed to help with build script was the |
IIRC the target abi was only matchable in build scripts, is that still the case today (with and without this PR)? To be able to lower the need for build scripts in the ecosystem we need cfgs to be at least isomorphic… |
This PR doesn't change anything for matching on specific target cfgs components. This PR only removes the shorthand As for the target abi, the |
Good. Thank you for the clarifications. |
This comment was marked as resolved.
This comment was marked as resolved.
79578af
to
9832308
Compare
This comment was marked as resolved.
This comment was marked as resolved.
9832308
to
1de1d84
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1de1d84
to
1f2c377
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1f2c377
to
7c50b97
Compare
This PR removes the unstable
cfg_target_compact
feature from #96901, which permits compacttarget(...)
cfgs (e.g.cfg(target(os = "linux"))
->cfg(target_os = "linux")
).The feature:
target_*
cfgsAll this to say that I don't think the feature pulls its weight.
@rustbot label +I-lang-nominated
Closes #96901