Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore ci_rustc_if_unchanged_logic test #131461

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

onur-ozkan
Copy link
Member

Temporary hotfix for unblocking CI.

r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 9, 2024
@onur-ozkan
Copy link
Member Author

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Oct 9, 2024

📌 Commit 41a811e has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024
@onur-ozkan
Copy link
Member Author

@bors r- (there is a typo in the FIXME comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2024
@onur-ozkan onur-ozkan force-pushed the ignore-ci-rustc-change-test branch from 41a811e to 118f7a6 Compare October 9, 2024 19:44
@onur-ozkan
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2024

📌 Commit 118f7a6 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 9, 2024
@bors
Copy link
Contributor

bors commented Oct 9, 2024

⌛ Testing commit 118f7a6 with merge eb4e234...

@bors
Copy link
Contributor

bors commented Oct 9, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing eb4e234 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2024
@bors bors merged commit eb4e234 into rust-lang:master Oct 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 9, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eb4e234): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Cycles

Results (secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.0%, 2.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.8s -> 775.436s (-0.18%)
Artifact size: 329.51 MiB -> 329.69 MiB (0.06%)

@onur-ozkan onur-ozkan deleted the ignore-ci-rustc-change-test branch October 10, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants