Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an error for unstable attributes that reference already stable features #131567

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Emit an error for unstable attributes that reference already stable features #131567

merged 1 commit into from
Oct 13, 2024

Conversation

CastilloDel
Copy link
Contributor

Closes #129814

@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2024
@CastilloDel CastilloDel changed the title Emit error when marking as unstable specifying an stable feature Emit an error for unstable attributes that reference already stable features Oct 11, 2024
@CastilloDel CastilloDel force-pushed the reject-unstable-with-accepted-features branch from ec46505 to ee15bd5 Compare October 11, 2024 20:25
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have one minor nit, then can you squash the commits into one?

tests/ui/feature-gates/unstable-attribute-rejects-already-stable-features.rs Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
@CastilloDel
Emit an error for unstable attributes that reference already stable f…
497100a 
…eatures

Add missing error annotations and .stderr file

Acknowledge comments
@CastilloDel CastilloDel force-pushed the reject-unstable-with-accepted-features branch from b3fcb09 to 497100a Compare October 12, 2024 08:19
@CastilloDel
Copy link
Contributor Author

Done!

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2024
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 12, 2024

📌 Commit 497100a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#131567 - CastilloDel:reject-unstable-with-a…
ddb0c61 
…ccepted-features, r=jieyouxu

Emit an error for unstable attributes that reference already stable features

Closes rust-lang#129814
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 12, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
@bors
Auto merge of rust-lang#131601 - matthiaskrgr:rollup-iaai3u5, r=matth…
222c99b 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def)
 - rust-lang#131233 (std: fix stdout-before-main)
 - rust-lang#131239 (Don't assume traits used as type are trait objs in 2021 edition)
 - rust-lang#131277 (Handle `clippy` cases of `rustc::potential_query_instability` lint)
 - rust-lang#131567 (Emit an error for unstable attributes that reference already stable features)
 - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`)
 - rust-lang#131590 (yeet some clones)
 - rust-lang#131597 (Take a display name for `tool_check_step!`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#131567 - CastilloDel:reject-unstable-with-a…
79d8116 
…ccepted-features, r=jieyouxu

Emit an error for unstable attributes that reference already stable features

Closes rust-lang#129814
This was referenced Oct 12, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
@bors
Auto merge of rust-lang#131628 - matthiaskrgr:rollup-imbojxz, r=matth…
ef4e825 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128784 (Check ABI target compatibility for function pointers)
 - rust-lang#130965 (make `Step` doc-comments more clear)
 - rust-lang#131239 (Don't assume traits used as type are trait objs in 2021 edition)
 - rust-lang#131277 (Handle `clippy` cases of `rustc::potential_query_instability` lint)
 - rust-lang#131503 (More clearly document Stdin::read_line)
 - rust-lang#131567 (Emit an error for unstable attributes that reference already stable features)
 - rust-lang#131599 (Shallowly match opaque key in storage)
 - rust-lang#131617 (remove const_cow_is_borrowed feature gate)

Failed merges:

 - rust-lang#131616 (merge const_ipv4 / const_ipv6 feature gate into 'ip' feature gate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b9e083f into rust-lang:master Oct 13, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@rust-timer
Unrolled build for rust-lang#131567
0c26e20 
Rollup merge of rust-lang#131567 - CastilloDel:reject-unstable-with-accepted-features, r=jieyouxu

Emit an error for unstable attributes that reference already stable features

Closes rust-lang#129814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

#[unstable] accepts an already-stable language feature
5 participants
@CastilloDel @rustbot @rust-log-analyzer @jieyouxu @bors