Rollup of 8 pull requests #131934

matthiaskrgr · 2024-10-19T15:25:36Z

Successful merges:

std: uefi: Add basic Env variables #127462 (std: uefi: Add basic Env variables)
Fix range misleading field access #131537 (Fix range misleading field access)
bootstrap: allow setting --jobs in config.toml #131838 (bootstrap: allow setting --jobs in config.toml)
Update use keyword docs to describe precise capturing #131890 (Update use keyword docs to describe precise capturing)
Mark unexpected variant res suggestion as having placeholders #131899 (Mark unexpected variant res suggestion as having placeholders)
rustdoc: Switch from FxHash to sha256 for static file hashing. #131908 (rustdoc: Switch from FxHash to sha256 for static file hashing.)
small interpreter error cleanup #131916 (small interpreter error cleanup)
zero-sized accesses are fine on null pointers #131919 (zero-sized accesses are fine on null pointers)

r? @ghost
@rustbot modify labels: rollup

Fixes rust-lang#131471 by checking if the range-start is a literal.

- Implement environment variable functions - Using EFI Shell protocol. Signed-off-by: Ayush Singh <[email protected]>

- Since in almost all cases, there will only be 1 UEFI shell, share the shell handle between all functions that require it. Signed-off-by: Ayush Singh <[email protected]>

…Kind

std: uefi: Add basic Env variables - Implement environment variable functions - Using EFI Shell protocol.

…errors Fix range misleading field access Fixes rust-lang#131471 by checking if the range-start is a literal.

bootstrap: allow setting `--jobs` in config.toml Allow setting `--jobs` in config.toml's `[build]` section. ```toml [build] jobs = 0 ``` If this is unset or set to zero in config.toml, we look at `--jobs` flag. If that is also unset, then we fallback to `std::thread::available_parallelism`. If that is not available, then we default to `1`. The flags and `available_parallelism` fallback are already setup, this PR just adds a config.toml option to wire that up. Closes rust-lang#131836. r? bootstrap

…traviscross Update `use` keyword docs to describe precise capturing I noticed that the standard library keyword docs for the `use` keyword haven't been updated yet to describe the new precise capturing syntax.

Mark unexpected variant res suggestion as having placeholders Fixes rust-lang#131878

…g, r=notriddle,GuillaumeGomez rustdoc: Switch from FxHash to sha256 for static file hashing. Fixes rust-lang#129533 (comment) fxhash isn't well defined, and it's implementation is being changed in rust-lang#129533. But because rustdoc uses it for static files (and encodes that hashing in rustdoc.css), this broke our tests. Given that this isn't performace critical, I think the right fix is to used a well-defined hash that will never change its definition. I've picked (rather arbitrarily) sha256.

small interpreter error cleanup - Add `InterpretResult::map_err_kind` for the common case of swapping out the error kind (while preserving the backtrace pointing to the original error source) - Rename `InterpError` -> `InterpErrorKind` to be consistent with the `kind` field name, and make it more clear that this is not the final error type

…pratt zero-sized accesses are fine on null pointers We entirely forgot to update all the function docs when changing the central docs. That's the problem with helpfully repeating shared definitions in tons of places...

matthiaskrgr · 2024-10-19T15:25:48Z

@bors r+ rollup=never p=8

bors · 2024-10-19T15:25:50Z

📌 Commit 7a6d436 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-10-19T16:46:47Z

⌛ Testing commit 7a6d436 with merge 8069f8d...

bors · 2024-10-19T19:57:51Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8069f8d to master...

rust-timer · 2024-10-19T20:00:04Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#127462	std: uefi: Add basic Env variables	`e1d29bd67749e9b6216a110ee0811a421a5f4ce2` (link)
#131537	Fix range misleading field access	`40fb3a1a79eb4fba365b1cd196129e3cca0bafe8` (link)
#131838	bootstrap: allow setting `--jobs` in config.toml	`09026144ae2fa7149c81ec3f25d17429692656b4` (link)
#131890	Update `use` keyword docs to describe precise capturing	`83f946eb690a3573382b7b65f456a8fc7f17321b` (link)
#131899	Mark unexpected variant res suggestion as having placeholde…	`73c97b655cdcc0370b7bceb017927fd78ff0eb7d` (link)
#131908	rustdoc: Switch from FxHash to sha256 for static file hashi…	`5a3fb77578c7d3d14c7abc4188ef512e96a0d75a` (link)
#131916	small interpreter error cleanup	`c340c6ffe193c6d0e8fc26ac4123842a1b54ef13` (link)
#131919	zero-sized accesses are fine on null pointers	`1f9cb31382a1eeffcbf7590b89f87aad94a2756e` (link)

previous master: a2a1206811

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-10-19T21:14:57Z

Finished benchmarking commit (8069f8d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	11
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.2%, 0.3%]	3

Max RSS (memory usage)

Results (secondary 4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[3.2%, 5.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 8.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.1%	[8.1%, 8.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 782.005s -> 781.277s (-0.09%)
Artifact size: 333.81 MiB -> 333.80 MiB (-0.00%)

lqd · 2024-10-19T22:18:07Z

The regressions are in rustdoc, so probably #131908.

…ime, r=<try> rustdoc: hash assets at rustdoc build time Since sha256 is slow enough to show up on small benchmarks, we can save time by embedding the hash in the executable. Addresses rust-lang#131934 (comment)

pnkfelix · 2024-10-21T19:13:57Z

primary regressions to helloworld (doc) and hyper (opt); primary improvement to libc (doc).
all the secondary regressions are to doc benchmarks, which led lqd to hypothesize that this is due to PR 131908 which changed the hash used for filename generation to sha256 since it should be stable going forward.
hyper history seems really noisy.
marking as triaged

@rustbot label: +perf-regression-triaged

…ime, r=GuillaumeGomez rustdoc: hash assets at rustdoc build time Since sha256 is slow enough to show up on small benchmarks, we can save time by embedding the hash in the executable. Addresses rust-lang#131934 (comment)

…illaumeGomez rustdoc: hash assets at rustdoc build time Since sha256 is slow enough to show up on small benchmarks, we can save time by embedding the hash in the executable. Addresses rust-lang/rust#131934 (comment)

hirschenberger and others added 17 commits October 18, 2024 17:27

Fix rust-lang#131471, range misleading field access

8f2273e

Fixes rust-lang#131471 by checking if the range-start is a literal.

Mark unexpected variant res suggestion as having placeholders

1617501

std: uefi: Add basic Env variables

588bfb4

- Implement environment variable functions - Using EFI Shell protocol. Signed-off-by: Ayush Singh <[email protected]>

std: uefi: Use common function for UEFI shell

753536a

- Since in almost all cases, there will only be 1 UEFI shell, share the shell handle between all functions that require it. Signed-off-by: Ayush Singh <[email protected]>

Update use keyword docs to describe precise capturing

be984c1

rustdoc: Switch from FxHash to sha256 for static file hashing.

3cf8a61

bootstrap: allow setting --jobs in config.toml

65458ae

interpret errors: add map_err_kind, rename InterpError -> InterpError…

eea74be

…Kind

zero-sized accesses are fine on null pointers

1b11ba8

Rollup merge of rust-lang#127462 - Ayush1325:uefi-env, r=joboet

5a3ecd5

std: uefi: Add basic Env variables - Implement environment variable functions - Using EFI Shell protocol.

Rollup merge of rust-lang#131537 - hirschenberger:master, r=compiler-…

a394d49

…errors Fix range misleading field access Fixes rust-lang#131471 by checking if the range-start is a literal.

Rollup merge of rust-lang#131890 - printfn:precise-capturing-docs, r=…

1cc036d

…traviscross Update `use` keyword docs to describe precise capturing I noticed that the standard library keyword docs for the `use` keyword haven't been updated yet to describe the new precise capturing syntax.

Rollup merge of rust-lang#131899 - compiler-errors:placeholder, r=lqd

ff55ec0

Mark unexpected variant res suggestion as having placeholders Fixes rust-lang#131878

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2024

bors merged commit 8069f8d into rust-lang:master Oct 19, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 19, 2024

This was referenced Oct 19, 2024

Compiletest: Custom differ #131181

Merged

Enable the llvm offload build configuration #131527

Merged

extend the "if-unchanged" logic for compiler builds #131831

Merged

Rollup of 6 pull requests #131938

Closed

rustbot added the perf-regression Performance regression. label Oct 19, 2024

notriddle mentioned this pull request Oct 19, 2024

rustdoc: hash assets at rustdoc build time #131951

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #131934

Rollup of 8 pull requests #131934

matthiaskrgr commented Oct 19, 2024

matthiaskrgr commented Oct 19, 2024

bors commented Oct 19, 2024

bors commented Oct 19, 2024

bors commented Oct 19, 2024

rust-timer commented Oct 19, 2024

rust-timer commented Oct 19, 2024

lqd commented Oct 19, 2024

pnkfelix commented Oct 21, 2024

Rollup of 8 pull requests #131934

Rollup of 8 pull requests #131934

Conversation

matthiaskrgr commented Oct 19, 2024

matthiaskrgr commented Oct 19, 2024

bors commented Oct 19, 2024

bors commented Oct 19, 2024

bors commented Oct 19, 2024

rust-timer commented Oct 19, 2024

rust-timer commented Oct 19, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Oct 19, 2024

pnkfelix commented Oct 21, 2024