-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpret: get_alloc_info: also return mutability #132801
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
It may be time to use a struct instead of a tuple 😀 |
Yeah... |
This comment has been minimized.
This comment has been minimized.
0918ff6
to
48de124
Compare
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
a30e9a6
to
a816ccd
Compare
This comment has been minimized.
This comment has been minimized.
…lication with validity checking
a816ccd
to
4a54ec8
Compare
interpret: get_alloc_info: also return mutability This will be needed for rust-lang/miri#3971 This then tuned into a larger refactor where we introduce a new type for the `get_alloc_info` return data, and we move some code to methods on `GlobalAlloc` to avoid duplicating it between the validity check and `get_alloc_info`.
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) r? `@ghost` `@rustbot` modify labels: rollup
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#132801 - RalfJung:alloc-mutability, r=oli-obk interpret: get_alloc_info: also return mutability This will be needed for rust-lang/miri#3971 This then tuned into a larger refactor where we introduce a new type for the `get_alloc_info` return data, and we move some code to methods on `GlobalAlloc` to avoid duplicating it between the validity check and `get_alloc_info`.
interpret: get_alloc_info: also return mutability This will be needed for rust-lang/miri#3971 This then tuned into a larger refactor where we introduce a new type for the `get_alloc_info` return data, and we move some code to methods on `GlobalAlloc` to avoid duplicating it between the validity check and `get_alloc_info`.
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
This will be needed for rust-lang/miri#3971
This then tuned into a larger refactor where we introduce a new type for the
get_alloc_info
return data, and we move some code to methods onGlobalAlloc
to avoid duplicating it between the validity check andget_alloc_info
.