Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not trust download-rustc=if-unchanged on CI for now #132852

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 10, 2024

See #131658.

Once #131831 lands this will be unnecessary, but until then, better safe than sorry.

r? @onur-ozkan
Cc @rust-lang/bootstrap

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 10, 2024
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 10, 2024

📌 Commit e1d09a5 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 10, 2024

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024
@RalfJung
Copy link
Member Author

@bors p=1

@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Ah right I forgot, an empty if is not valid bash syntax 🤦

@RalfJung
Copy link
Member Author

@bors r=onur-ozkan

@bors
Copy link
Contributor

bors commented Nov 10, 2024

📌 Commit 146e744 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 10, 2024

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@RalfJung
Copy link
Member Author

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Nov 10, 2024

⌛ Testing commit 146e744 with merge 1cbb252...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2024
…ozkan

do not trust download-rustc=if-unchanged on CI for now

See rust-lang#131658.

Once rust-lang#131831 lands this will be unnecessary, for until then, better safe than sorry.

r? `@onur-ozkan`
Cc `@rust-lang/bootstrap`
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Nov 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@RalfJung
Copy link
Member Author

@bors r=onur-ozkan retry

@bors
Copy link
Contributor

bors commented Nov 10, 2024

📌 Commit 5c9cc0c has been approved by onur-ozkan

It is now in the queue for this repository.

@rust-log-analyzer

This comment was marked as outdated.

@bors
Copy link
Contributor

bors commented Nov 10, 2024

⌛ Testing commit 5c9cc0c with merge f5b6257...

@bors
Copy link
Contributor

bors commented Nov 10, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing f5b6257 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2024
@bors bors merged commit f5b6257 into rust-lang:master Nov 10, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 10, 2024
@RalfJung RalfJung deleted the rustc-if-unchanged branch November 10, 2024 18:08
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f5b6257): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [0.5%, 5.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.4%, secondary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
4.6% [4.6%, 4.6%] 1
Improvements ✅
(primary)
-3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) -0.4% [-3.4%, 2.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 787.115s -> 786.513s (-0.08%)
Artifact size: 335.35 MiB -> 335.31 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 10, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Nov 10, 2024

Noise, this only modified CI.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 10, 2024
@Mark-Simulacrum Mark-Simulacrum removed perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. labels Nov 11, 2024
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
…ozkan

do not trust download-rustc=if-unchanged on CI for now

See rust-lang#131658.

Once rust-lang#131831 lands this will be unnecessary, for until then, better safe than sorry.

r? `@onur-ozkan`
Cc `@rust-lang/bootstrap`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants