-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not trust download-rustc=if-unchanged on CI for now #132852
Conversation
@bors r+ |
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
@bors p=1 |
This comment has been minimized.
This comment has been minimized.
Ah right I forgot, an empty if is not valid bash syntax 🤦 |
e1d09a5
to
146e744
Compare
@bors r=onur-ozkan |
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
@bors treeclosed- |
…ozkan do not trust download-rustc=if-unchanged on CI for now See rust-lang#131658. Once rust-lang#131831 lands this will be unnecessary, for until then, better safe than sorry. r? `@onur-ozkan` Cc `@rust-lang/bootstrap`
146e744
to
5c9cc0c
Compare
This PR modifies cc @jieyouxu |
@bors r=onur-ozkan retry |
This comment was marked as outdated.
This comment was marked as outdated.
☀️ Test successful - checks-actions |
Finished benchmarking commit (f5b6257): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.4%, secondary 1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 787.115s -> 786.513s (-0.08%) |
Noise, this only modified CI. @rustbot label: +perf-regression-triaged |
…ozkan do not trust download-rustc=if-unchanged on CI for now See rust-lang#131658. Once rust-lang#131831 lands this will be unnecessary, for until then, better safe than sorry. r? `@onur-ozkan` Cc `@rust-lang/bootstrap`
See #131658.
Once #131831 lands this will be unnecessary, but until then, better safe than sorry.
r? @onur-ozkan
Cc @rust-lang/bootstrap