Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor where predicates, and reserve for attributes support #132894

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Refactor where predicates, and reserve for attributes support #132894

merged 1 commit into from
Nov 26, 2024

Conversation

frank-king
Copy link
Contributor

Refactor WherePredicate to WherePredicateKind, and reserve for attributes support in where predicates.

This is a part of #115590 and is split from #132388.

r? petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2024

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

HIR ty lowering was modified

cc @fmease

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@frank-king frank-king mentioned this pull request Nov 11, 2024
Open
@frank-king frank-king force-pushed the feature/where-refactor branch from 2564d04 to 78668c5 Compare November 11, 2024 08:04
petrochenkov
petrochenkov reviewed Nov 16, 2024
View reviewed changes
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/mut_visit.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/generics.rs Outdated Show resolved Hide resolved
compiler/rustc_hir/src/target.rs Outdated Show resolved Hide resolved
compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_pretty/src/pprust/state/item.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024
@frank-king frank-king force-pushed the feature/where-refactor branch from 78668c5 to d71d19e Compare November 17, 2024 14:27
@frank-king
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2024
@petrochenkov
Copy link
Contributor

r? @cjgillot

@rustbot rustbot assigned cjgillot and unassigned petrochenkov Nov 19, 2024
@bors
Copy link
Contributor

bors commented Nov 19, 2024

☔ The latest upstream changes (presumably #133205) made this pull request unmergeable. Please resolve the merge conflicts.

@frank-king frank-king force-pushed the feature/where-refactor branch from d71d19e to 7e9e86b Compare November 20, 2024 01:08
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in src/tools/cargo

cc @ehuss

@frank-king frank-king force-pushed the feature/where-refactor branch from 7e9e86b to 5bb8061 Compare November 20, 2024 01:15
@cjgillot
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2024
@bors
Auto merge of rust-lang#132894 - frank-king:feature/where-refactor, r…
41a5793 
…=<try>

Refactor `where` predicates, and reserve for attributes support

Refactor `WherePredicate` to `WherePredicateKind`, and reserve for attributes support in `where` predicates.

This is a part of rust-lang#115590 and is split from rust-lang#132388.

r? petrochenkov
@bors
Copy link
Contributor

bors commented Nov 22, 2024

⌛ Trying commit 5bb8061 with merge 41a5793...

@bors
Copy link
Contributor

bors commented Nov 22, 2024

☀️ Try build successful - checks-actions
Build commit: 41a5793 (41a5793fd9ac2b2ba2c6a23961e2914fcfe2f357)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (41a5793): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.1%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)		 -3.1% [-3.5%, -2.8%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.1% [-3.5%, -2.8%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.222s -> 798.07s (0.23%)
Artifact size: 336.06 MiB -> 336.08 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 22, 2024
@frank-king frank-king force-pushed the feature/where-refactor branch from 5bb8061 to 161221d Compare November 25, 2024 08:40
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2024

📌 Commit 161221d has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2024
@bors
Copy link
Contributor

bors commented Nov 26, 2024

⌛ Testing commit 161221d with merge f2abf82...

@bors
Copy link
Contributor

bors commented Nov 26, 2024

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing f2abf82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 26, 2024
@bors bors merged commit f2abf82 into rust-lang:master Nov 26, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 26, 2024
@bors bors mentioned this pull request Nov 26, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f2abf82): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.797s -> 795.777s (-0.13%)
Artifact size: 336.29 MiB -> 336.33 MiB (0.01%)

@frank-king frank-king deleted the feature/where-refactor branch November 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov approved these changes

Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@frank-king @rustbot @petrochenkov @bors @cjgillot @rust-timer