Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triagebot.toml #132942

Closed
wants to merge 1 commit into from
Closed

Conversation

dcollins123
Copy link

Improved PR notification messages and clarified comments for support of multiple actions on stable accepted events

Improved PR notification messages and clarified comments for support of multiple actions on stable accepted events
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Nov 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2024

Error: Invalid triagebot.toml at position 562:1:

TOML parse error at line 562, column 1
    |
562 | [notify-zulip."stable-accepted"]
    | ^
invalid table header
duplicate key `stable-accepted` in table `notify-zulip`

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing an interest in contributing to rustc.

I don't understand what this PR is trying to do. Your change doesn't address the FIXME at all, if that's what you meant to do?

You can't just rename [notify-zulip."beta-accepted"] to [notify-zulip."stable-accepted"], the entry is entirely correct as is. We have 4 entries, each one corresponding to a label. The 4 labels are beta-nominated, beta-accepted, stable-nominated and stable-accepted. You made us lose the entry for beta-accepted and essentially duplicated the entry for stable-accepted which is not valid TOML at that as seen by the bot response.

Furthermore, triagebot doesn't use ${…} for variable substitution, it's {…}.

Lastly, we already have someone working on addressing the 4 FIXMEs. CC rust-lang/triagebot#1853.

I have to close this PR because I don't see a way to remedy it. I hope this doesn't discourage you from contributing in the future though!

@fmease fmease closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants