[AIX] Add option -X32_64 to the "strip" command

[xingxue-ibm]

The AIX strip utility requires option -X to specify the object mode. This patch adds the -X32_64 option to the strip command so that it can handle both 32-bit and 64-bit objects. The parameter option of function strip_symbols_with_external_utility, previously a single string, has been changed to options, an array of string slices, to accommodate multiple strip options.

[rustbot]

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[mustartt]

nit: consider changing Option<&[String]> to maybe &[&str] so we don't need to use to_string.

[xingxue-ibm]

nit: consider changing Option<&[String]> to maybe &[&str] so we don't need to use to_string.

Good point, thanks!

[lqd]

Similarly you don't need the vec.

[xingxue-ibm]

Similarly you don't need the vec.

Thanks for pointing this out, @lqd! This makes the code much better!

[lqd]

Sure, no problem.

Also, from a quick read:

• you probably don't need the Option, and could use empty slices for no options
• can likely use https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/back/command/struct.Command.html#method.args in strip_symbols_with_external_utility
• (also, it'd be better to squash the commits)

[xingxue-ibm]

Sure, no problem.

Also, from a quick read:

* you probably don't need the Option, and could use empty slices for no options

* can likely use https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/back/command/struct.Command.html#method.args in `strip_symbols_with_external_utility`

* (also, it'd be better to squash the commits)

Done. Thank you so much for the guidance, @lqd!

[xingxue-ibm]

@rustbot review

[compiler-errors]

@bors r+

[bors]

📌 Commit 02f51ec has been approved by compiler-errors

It is now in the queue for this repository.

[mustartt]

This fixes a lot of test cases on AIX and allows the strip to function properly without OBJECT_MODE=64.

@rustbot label beta-nominate

[rustbot]

Error: Label beta-nominate can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[mustartt]

@rustbot label beta-nominated

[apiraino]

Beta backport declined as per compiler team on Zulip. As far as we can see this is not fixing a regression, so we think it can wait the next release cycle

@rustbot label -beta-nominated

[davidtwco]

Thanks for taking the time to fix this bug. Just to add to what @apiraino has said, the project's backport policy describes how we typically only backport regressions, and as far as we can tell, this isn't a regression, it's always been an issue. We also weigh up the risk vs reward for a backport, how likely a change is to break something vs how critical the issue is (can it be worked around, is it on a tier one platform, etc).