Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Solaris target information, adds Solaris maintainer #133293

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Updates Solaris target information, adds Solaris maintainer #133293

merged 1 commit into from
Dec 15, 2024
+38 −4

Conversation

psumbera
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@psumbera
Copy link
Contributor Author

psumbera commented Nov 21, 2024 •
edited
Loading

Following yesterdays discussion. @cuviper @tgross35 @workingjubilee.

@GuillaumeGomez
Copy link
Member

r? Noratrieb

@rustbot rustbot assigned Noratrieb and unassigned GuillaumeGomez Nov 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper
Copy link
Member

cuviper commented Nov 21, 2024

NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md

workingjubilee
workingjubilee approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah.

@jieyouxu
Copy link
Member

NOTE: if you are adding or renaming a markdown file in a mdBook, don't forget to register the page in SUMMARY.md

Great to see I'm not the only one who forgets about it 😆

jieyouxu
jieyouxu approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great and thank you for signing up to be its target maintainer. I'll tag this with compat relnotes as we're technically changing the baseline -- but previously there was no explicit baseline at all!

@jieyouxu jieyouxu added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 22, 2024
@rustbot rustbot mentioned this pull request Nov 22, 2024
Open
3 tasks
@Noratrieb
Copy link
Member

@workingjubilee @jieyouxu I don't think there's anything blocking this PR? Can this be merged?

@jieyouxu
Copy link
Member

@workingjubilee @jieyouxu I don't think there's anything blocking this PR? Can this be merged?

(We didn't know if a Tier 2 solaris baseline change needed an FCP, I'm inclined to say "no" in this case because this was previously underspecified and relnotes is likely sufficient)

@tgross35 tgross35 mentioned this pull request Dec 3, 2024
Closed
3 tasks
@tgross35
Copy link
Contributor

tgross35 commented Dec 3, 2024

I posted an MCP just to make sure there aren't any objections rust-lang/compiler-team#812. I think we're more interested in the internal FYI and the concern period rather than technical details, so anyone feel free to second :)

@RalfJung RalfJung mentioned this pull request Dec 4, 2024
Open
57 tasks
@Noratrieb
Copy link
Member

r? tgross35 assigning you to approve once the MCP is through

@rustbot rustbot assigned tgross35 and unassigned Noratrieb Dec 7, 2024
@tgross35
Copy link
Contributor

MCP completes tomorrow, I don't really see us getting any last minute objections.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2024

📌 Commit 38fc918 has been approved by tgross35

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 12, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Dec 12, 2024 •
edited
Loading

@tgross35 let's just wait for MCP to finish (it's only 1 day away anyway), there's no need to rush this change through.

@jieyouxu
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2024
@jieyouxu jieyouxu added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2024
@tgross35
Copy link
Contributor

Now it's complete :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 14, 2024

📌 Commit 38fc918 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 14, 2024
@tgross35
Copy link
Contributor

@bors r=workingjubilee,jieyouxu,tgross35 add the other approvers

@bors
Copy link
Contributor

bors commented Dec 14, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 14, 2024

📌 Commit 38fc918 has been approved by workingjubilee,jieyouxu,tgross35

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2024
Merged
@tgross35 tgross35 removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Dec 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
@bors
Auto merge of rust-lang#134318 - matthiaskrgr:rollup-jda0jkx, r=matth…
7caf35b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#132939 (Suggest using deref in patterns)
 - rust-lang#133293 (Updates Solaris target information, adds Solaris maintainer)
 - rust-lang#133392 (Fix ICE when multiple supertrait substitutions need assoc but only one is provided)
 - rust-lang#133986 (Add documentation for anonymous pipe module)
 - rust-lang#134022 (Doc: Extend for tuples to be stabilized in 1.85.0)
 - rust-lang#134259 (Clean up `infer_return_ty_for_fn_sig`)
 - rust-lang#134264 (Arbitrary self types v2: Weak & NonNull diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ecfa09a into rust-lang:master Dec 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
@rust-timer
Unrolled build for rust-lang#133293
f22f08a 
Rollup merge of rust-lang#133293 - psumbera:solaris-maintainer, r=workingjubilee,jieyouxu,tgross35

Updates Solaris target information, adds Solaris maintainer
@cuviper cuviper mentioned this pull request Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
10 participants
@psumbera @rustbot @GuillaumeGomez @rust-log-analyzer @cuviper @jieyouxu @Noratrieb @tgross35 @bors @workingjubilee