Structurally resolve in `adjust_for_branches` #133559

compiler-errors · 2024-11-28T01:00:32Z

r? lcnr

lcnr

looking through the api of Expectation, there's also fn resolve which I believe should also normalize with the new solver and we can probably craft tests for all/mosts its use-sites.

adjust_for_branches can then simply match on self.resolve(fcx, expr.span) 🤔

compiler-errors · 2024-11-29T21:37:47Z

@rustbot ready

So, structurally resolving means that we now eagerly process obligations which affects our ability to deduplicate reported predicates. Diagnostics have gotten kinda bad for RPITs in the new solver and with GCE, but I guess we could fix that later.

@bors try @rust-timer queue

…-adjust-for-branch, r=<try> Structurally resolve before `adjust_for_branches` r? lcnr

bors · 2024-11-29T21:38:59Z

⌛ Trying commit 28c13d2 with merge 83a6b38...

compiler-errors · 2024-11-29T21:51:19Z

compiler/rustc_hir_typeck/src/expectation.rs

-    /// there is no expected type or resolution is not possible (e.g.,
-    /// no constraints yet present), just returns `self`.
-    fn resolve(self, fcx: &FnCtxt<'a, 'tcx>) -> Expectation<'tcx> {
+    pub(super) fn structurally_resolve(


I decided to rename these methods to make it clear that they structurally resolve.

bors · 2024-11-29T23:22:54Z

☀️ Try build successful - checks-actions
Build commit: 83a6b38 (83a6b382ebc492b238d1aa2af24f535554094639)

rust-timer · 2024-11-30T01:11:40Z

Finished benchmarking commit (83a6b38): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 3.0%]	16
Regressions ❌ (secondary)	2.2%	[0.4%, 4.2%]	21
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.2%, 3.0%]	16

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.9%, 1.7%]	2
Regressions ❌ (secondary)	2.8%	[2.1%, 3.5%]	4
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-6.4%	[-6.4%, -6.4%]	1
All ❌✅ (primary)	0.5%	[-1.1%, 1.7%]	3

Cycles

Results (primary 1.5%, secondary 4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	4.0%	[3.5%, 4.5%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.899s -> 773.602s (0.22%)
Artifact size: 332.31 MiB -> 332.33 MiB (0.01%)

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 ### commits - rust-lang#133643 - ce66d92 is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now * rust-lang#133559 * rust-lang#133558 r? `@ghost`

compiler-errors · 2024-12-04T20:37:26Z

@bors try @rust-timer queue

rust-timer · 2024-12-05T00:51:54Z

Finished benchmarking commit (e77448a): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.4%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.1%, 0.4%]	3

Max RSS (memory usage)

Results (secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.678s -> 768.393s (-0.17%)
Artifact size: 330.86 MiB -> 330.85 MiB (-0.00%)

compiler-errors · 2024-12-05T00:56:33Z

I think perf is insignificant but I guess I could gate the structural resolve behind -Znext-solver if @lcnr cares much about it.

lcnr · 2024-12-05T08:56:01Z

nah

@bors r+

bors · 2024-12-05T08:56:05Z

📌 Commit 0cf9370 has been approved by lcnr

It is now in the queue for this repository.

…-adjust-for-branch, r=lcnr Structurally resolve in `adjust_for_branches` r? lcnr

bors · 2024-12-05T10:20:18Z

⌛ Testing commit 0cf9370 with merge f159751...

bors · 2024-12-05T14:35:18Z

💥 Test timed out

…-adjust-for-branch, r=lcnr Structurally resolve in `adjust_for_branches` r? lcnr

bors · 2024-12-05T15:32:10Z

⌛ Testing commit 0cf9370 with merge eed8504...

rust-log-analyzer · 2024-12-05T17:52:39Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 31.391
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-96d0305fb1a0ac21.rustc_main.59b9f1ac06694cdc-cgu.0.rcgu.o" "-Wl,-Bdynamic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_driver-9266893fdc6ace7c.dll" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\std-85e8e1afc0a1e2c0.dll" "-Wl,-Bstatic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-d77c9d76f065957b.rlib" "-Wl,-Bdynamic" "-lpsapi" "-lshell32" "-lole32" "-luuid" "-ladvapi32" "-lws2_32" "-lntdll" "-lkernel32" "-ladvapi32" "-lole32" "-loleaut32" "-ladvapi32" "-lcfgmgr32" "-lgdi32" "-lkernel32" "-lmsimg32" "-lopengl32" "-luser32" "-lwinspool" "-lbcrypt" "-ladvapi32" "-lkernel32" "-lkernel32" "-ladvapi32" "-lntdll" "-luserenv" "-lws2_32" "-ldbghelp" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcqihZTk\\wofutil.dll_imports_indirect.lib" "-lgcc_s" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmingwex" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\stacker-d3f5f2020a9db92d\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\psm-209b3c2f591fdc56\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\blake3-a0d1954ccec93ff8\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\rustc_llvm-9c1d12dc9076cada\\out" "-L" "C:/a/rust/rust/build/i686-pc-windows-gnu/llvm/lib" "-L" "C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0" "-o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-96d0305fb1a0ac21.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\a\rust\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\deps\rustc_main-96d0305fb1a0ac21.exe: Invalid argument␍
          collect2.exe: error: ld returned 1 exit status

[RUSTC-TIMING] rustc_main test:false 4.162
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:34:28

bors · 2024-12-05T17:53:13Z

💔 Test failed - checks-actions

compiler-errors · 2024-12-05T17:56:53Z

:(

@bors retry

bors · 2024-12-06T04:55:38Z

⌛ Testing commit 0cf9370 with merge acf4842...

bors · 2024-12-06T07:43:20Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing acf4842 to master...

rust-timer · 2024-12-06T09:11:32Z

Finished benchmarking commit (acf4842): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	2

Max RSS (memory usage)

Results (secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.4%, 2.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.2%	[-6.3%, -6.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.915s -> 769.005s (-0.12%)
Artifact size: 330.89 MiB -> 330.87 MiB (-0.01%)

rustbot assigned lcnr Nov 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2024

compiler-errors force-pushed the structurally-resolve-adjust-for-branch branch from 4a70611 to 11908bc Compare November 28, 2024 01:03

rustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Nov 28, 2024

This comment has been minimized.

Sign in to view

lcnr reviewed Nov 28, 2024

View reviewed changes

lcnr mentioned this pull request Nov 28, 2024

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Draft

Structurally resolve before adjust_for_branches

0ac93cd

lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2024

compiler-errors force-pushed the structurally-resolve-adjust-for-branch branch from 11908bc to 28c13d2 Compare November 29, 2024 21:32

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024

Auto merge of rust-lang#133559 - compiler-errors:structurally-resolve…

83a6b38

…-adjust-for-branch, r=<try> Structurally resolve before `adjust_for_branches` r? lcnr

compiler-errors commented Nov 29, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 30, 2024

compiler-errors force-pushed the structurally-resolve-adjust-for-branch branch from 28c13d2 to cfe3a82 Compare December 4, 2024 20:37

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 5, 2024

Resolve more

0cf9370

compiler-errors force-pushed the structurally-resolve-adjust-for-branch branch from cfe3a82 to 0cf9370 Compare December 5, 2024 00:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2024

lcnr changed the title ~~Structurally resolve before adjust_for_branches~~ Structurally resolve in adjust_for_branches Dec 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024

Auto merge of rust-lang#133559 - compiler-errors:structurally-resolve…

f159751

…-adjust-for-branch, r=lcnr Structurally resolve in `adjust_for_branches` r? lcnr

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024

Auto merge of rust-lang#133559 - compiler-errors:structurally-resolve…

eed8504

…-adjust-for-branch, r=lcnr Structurally resolve in `adjust_for_branches` r? lcnr

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 6, 2024

bors merged commit acf4842 into rust-lang:master Dec 6, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 6, 2024

rustbot removed the perf-regression Performance regression. label Dec 6, 2024

jieyouxu added the CI-spurious-fail-mingw CI spurious failure: target env mingw label Dec 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Structurally resolve in `adjust_for_branches` #133559

Structurally resolve in `adjust_for_branches` #133559

compiler-errors commented Nov 28, 2024

This comment has been minimized.

lcnr left a comment •

edited

Loading

compiler-errors commented Nov 29, 2024

This comment has been minimized.

bors commented Nov 29, 2024

compiler-errors Nov 29, 2024

This comment has been minimized.

bors commented Nov 29, 2024

This comment has been minimized.

rust-timer commented Nov 30, 2024

compiler-errors commented Dec 4, 2024

This comment has been minimized.

rust-timer commented Dec 5, 2024

compiler-errors commented Dec 5, 2024

lcnr commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

rust-log-analyzer commented Dec 5, 2024

bors commented Dec 5, 2024

compiler-errors commented Dec 5, 2024

bors commented Dec 6, 2024

bors commented Dec 6, 2024

rust-timer commented Dec 6, 2024

Structurally resolve in adjust_for_branches #133559

Structurally resolve in adjust_for_branches #133559

Conversation

compiler-errors commented Nov 28, 2024

This comment has been minimized.

lcnr left a comment • edited Loading

Choose a reason for hiding this comment

compiler-errors commented Nov 29, 2024

This comment has been minimized.

bors commented Nov 29, 2024

Choose a reason for hiding this comment

This comment has been minimized.

bors commented Nov 29, 2024

This comment has been minimized.

rust-timer commented Nov 30, 2024

Overall result: ❌ regressions - please read the text below

compiler-errors commented Dec 4, 2024

This comment has been minimized.

rust-timer commented Dec 5, 2024

Overall result: ❌ regressions - please read the text below

compiler-errors commented Dec 5, 2024

lcnr commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

bors commented Dec 5, 2024

rust-log-analyzer commented Dec 5, 2024

bors commented Dec 5, 2024

compiler-errors commented Dec 5, 2024

bors commented Dec 6, 2024

bors commented Dec 6, 2024

rust-timer commented Dec 6, 2024

Overall result: ❌ regressions - no action needed

Structurally resolve in `adjust_for_branches` #133559

Structurally resolve in `adjust_for_branches` #133559

lcnr left a comment •

edited

Loading