Some asm! diagnostic adjustments and a papercut fix #134070

oli-obk · 2024-12-09T11:05:21Z

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

rustbot · 2024-12-09T11:05:33Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/asm/named_const_simd_vec_len.stderr

jieyouxu · 2024-12-09T11:09:51Z

r? jieyouxu

jieyouxu

Thanks, this looks good to me. The diagnostics indeed look significantly nicer!

jieyouxu · 2024-12-09T13:24:55Z

@bors r+ rollup

bors · 2024-12-09T13:24:59Z

📌 Commit f167d3c has been approved by jieyouxu

It is now in the queue for this repository.

Some asm! diagnostic adjustments and a papercut fix Best reviewed commit by commit. We forgot a `normalize` call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright. The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

Rollup of 9 pull requests Successful merges: - rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates) - rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX) - rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command) - rust-lang#134008 (Make `Copy` unsafe to implement for ADTs with `unsafe` fields) - rust-lang#134017 (Don't use `AsyncFnOnce::CallOnceFuture` bounds for signature deduction) - rust-lang#134023 (handle cygwin environment in `install::sanitize_sh`) - rust-lang#134041 (Use SourceMap to load debugger visualizer files) - rust-lang#134065 (Move `write_graphviz_results`) - rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2024-12-10T07:47:17Z

#134097 (comment)
@bors r-

oli-obk · 2024-12-10T08:40:37Z

limited the test to x86

@bors r=jieyouxu

bors · 2024-12-10T08:40:41Z

📌 Commit c7088b2 has been approved by jieyouxu

It is now in the queue for this repository.

Some asm! diagnostic adjustments and a papercut fix Best reviewed commit by commit. We forgot a `normalize` call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright. The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

fmease · 2024-12-10T19:17:28Z

The other test needs to be limited, too.

oli-obk · 2024-12-11T16:50:03Z

@bors r=jieyouxu

bors · 2024-12-11T16:50:06Z

📌 Commit 53d2931 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2024-12-11T17:18:30Z

In the second commit, there's an empty stderr file as the test became run-pass.
@bors r-

oli-obk · 2024-12-11T18:54:02Z

What the heck xD I blessed all ui tests in all commits...

jieyouxu · 2024-12-12T04:30:13Z

What the heck xD I blessed all ui tests in all commits...

Hm, this might be a compiletest bug, where if u had a previous stderr from check-fail then u change it to check-pass it might write empty stderr but keep the file... I'll open an issue later.

jieyouxu

Thanks!

jieyouxu · 2024-12-12T04:30:55Z

@bors r+

bors · 2024-12-12T04:30:57Z

📌 Commit 98edb8f has been approved by jieyouxu

It is now in the queue for this repository.

Some asm! diagnostic adjustments and a papercut fix Best reviewed commit by commit. We forgot a `normalize` call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright. The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

Rollup of 13 pull requests Successful merges: - rust-lang#122003 (link libunwind dynamically and allow controlling it via `crt-static` on gnullvm targets) - rust-lang#133122 (Add unpolished, experimental support for AFIDT (async fn in dyn trait)) - rust-lang#133859 (Move some alloc tests to the alloctests crate) - rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix) - rust-lang#134095 ([CI] Use a lockfile for installing the `datadog` package) - rust-lang#134144 (Properly consider APITs for never type fallback ascription fix) - rust-lang#134152 (Simplify `rustc_mir_dataflow::abs_domain`.) - rust-lang#134154 (suppress field expr with generics error message if it's a method) - rust-lang#134155 (Forbid `unsafe_op_in_unsafe_fn` for Hurd) - rust-lang#134173 (allow `symbol_intern_string_literal` lint in test modules) - rust-lang#134178 (Stabilize the Rust 2024 prelude) - rust-lang#134179 (Remove outdated consteval note from `<*mut T>::align_offset` docs.) - rust-lang#134187 (Remove `PErr`.) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#122003 (link libunwind dynamically and allow controlling it via `crt-static` on gnullvm targets) - rust-lang#133859 (Move some alloc tests to the alloctests crate) - rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix) - rust-lang#134144 (Properly consider APITs for never type fallback ascription fix) - rust-lang#134152 (Simplify `rustc_mir_dataflow::abs_domain`.) - rust-lang#134154 (suppress field expr with generics error message if it's a method) - rust-lang#134155 (Forbid `unsafe_op_in_unsafe_fn` for Hurd) - rust-lang#134173 (allow `symbol_intern_string_literal` lint in test modules) - rust-lang#134178 (Stabilize the Rust 2024 prelude) - rust-lang#134179 (Remove outdated consteval note from `<*mut T>::align_offset` docs.) - rust-lang#134187 (Remove `PErr`.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134070 - oli-obk:push-nquzymupzlsq, r=jieyouxu Some asm! diagnostic adjustments and a papercut fix Best reviewed commit by commit. We forgot a `normalize` call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright. The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

rustbot assigned davidtwco Dec 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2024

oli-obk changed the title ~~Clarify why a type is rejected for asm!~~ Some asm! diagnostic adjustments and a papercut fix Dec 9, 2024

jieyouxu reviewed Dec 9, 2024

View reviewed changes

tests/ui/asm/named_const_simd_vec_len.stderr Outdated Show resolved Hide resolved

rustbot assigned jieyouxu and unassigned davidtwco Dec 9, 2024

This comment has been minimized.

Sign in to view

oli-obk force-pushed the push-nquzymupzlsq branch from e9dcd96 to f167d3c Compare December 9, 2024 11:55

jieyouxu approved these changes Dec 9, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024

fmease mentioned this pull request Dec 9, 2024

Rollup of 9 pull requests #134097

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2024

oli-obk force-pushed the push-nquzymupzlsq branch 2 times, most recently from 05a8c23 to c7088b2 Compare December 10, 2024 08:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2024

fmease mentioned this pull request Dec 10, 2024

Rollup of 9 pull requests #134133

Closed

Add regression tests

c04b52a

oli-obk force-pushed the push-nquzymupzlsq branch from c7088b2 to 53d2931 Compare December 11, 2024 16:49

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2024

oli-obk added 2 commits December 11, 2024 20:17

Evaluate constants in SIMD vec lengths before rejecting them

6d3d61f

Clarify why a type is rejected for asm!

98edb8f

oli-obk force-pushed the push-nquzymupzlsq branch from 53d2931 to 98edb8f Compare December 11, 2024 20:17

jieyouxu approved these changes Dec 12, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2024

This was referenced Dec 12, 2024

Rollup of 13 pull requests #134195

Closed

compiletest: empty stderr if check-fail -> check-pass #134196

Open

matthiaskrgr mentioned this pull request Dec 12, 2024

Rollup of 11 pull requests #134201

Merged

bors merged commit fed24af into rust-lang:master Dec 12, 2024
6 checks passed

rustbot added this to the 1.85.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some asm! diagnostic adjustments and a papercut fix #134070

Some asm! diagnostic adjustments and a papercut fix #134070

oli-obk commented Dec 9, 2024 •

edited

Loading

rustbot commented Dec 9, 2024

jieyouxu commented Dec 9, 2024

This comment has been minimized.

jieyouxu left a comment •

edited

Loading

jieyouxu commented Dec 9, 2024

bors commented Dec 9, 2024

fmease commented Dec 10, 2024

oli-obk commented Dec 10, 2024

bors commented Dec 10, 2024

fmease commented Dec 10, 2024 •

edited

Loading

oli-obk commented Dec 11, 2024

bors commented Dec 11, 2024

This comment has been minimized.

jieyouxu commented Dec 11, 2024

oli-obk commented Dec 11, 2024

jieyouxu commented Dec 12, 2024

jieyouxu left a comment

jieyouxu commented Dec 12, 2024

bors commented Dec 12, 2024

Some asm! diagnostic adjustments and a papercut fix #134070

Some asm! diagnostic adjustments and a papercut fix #134070

Conversation

oli-obk commented Dec 9, 2024 • edited Loading

rustbot commented Dec 9, 2024

jieyouxu commented Dec 9, 2024

This comment has been minimized.

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

jieyouxu commented Dec 9, 2024

bors commented Dec 9, 2024

fmease commented Dec 10, 2024

oli-obk commented Dec 10, 2024

bors commented Dec 10, 2024

fmease commented Dec 10, 2024 • edited Loading

oli-obk commented Dec 11, 2024

bors commented Dec 11, 2024

This comment has been minimized.

jieyouxu commented Dec 11, 2024

oli-obk commented Dec 11, 2024

jieyouxu commented Dec 12, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Dec 12, 2024

bors commented Dec 12, 2024

oli-obk commented Dec 9, 2024 •

edited

Loading

jieyouxu left a comment •

edited

Loading

fmease commented Dec 10, 2024 •

edited

Loading