Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Read and Write on Arc<TcpStream> and Arc<UnixStream>. #134190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Read and Write on Arc<TcpStream> and Arc<UnixStream>. #134190

wants to merge 2 commits into from
+84 −0

Conversation

nmathewson
Copy link
Contributor

By analogy to #94748, this PR makes Arc<TcpStream> and Arc<UnixStream> implement Read and Write, which are already implemented on &TcpStream and &UnixStream.

This is my first non-documentation patch on the library; it's quite possible that I have gotten something wrong, especially surrounding the #[stable] attribute.

CC #53835
CC #94744

@nmathewson
impl Read and Write on Arc<TcpStream>
496efeb 
By analogy to rust-lang#94748, this change makes `Arc<TcpStream>` implement
these traits that are already implemented on `&TcpStream`.
@nmathewson
impl Read and Write on Arc<UnixStream>
af69df7 
By analogy to rust-lang#94748, this change makes `Arc<UnixStream>` implement
these traits that are already implemented on `&UnixStream`.
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2024

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 12, 2024
@Noratrieb
Copy link
Member

Thank you for the PR! This PR contains a public library API change, which should follow the proper process of creating an ACP first: https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html
Use @rustbot ready when your ACP has been accepeted.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2024
@nmathewson nmathewson mentioned this pull request Dec 12, 2024
Open
@nmathewson
Copy link
Contributor Author

Okay, ACP at rust-lang/libs-team#504. Let's see how they like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
O-unix Operating system: Unix-like S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmathewson @rustbot @Noratrieb