Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rustc_encodable_decodable feature properly unstable #134272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RalfJung
Copy link
Member

This has been shown in future-compat reports since Rust 1.79 (#116016). Let's see if crater still finds any issues.

Cc @rust-lang/libs-api

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 13, 2024
@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 2993504 to 3ce5d1d Compare December 13, 2024 17:38
@RalfJung
Copy link
Member Author

RalfJung commented Dec 13, 2024

Hm, seeing the discussion in #116016 it seems like the plan was to move much more slowly with this? There's no separate tracking issue for the de-stabilization of this as far as I can see, so it's all a bit unclear.

I guess we'll see what crater says.
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
…_decodable, r=<try>

make rustc_encodable_decodable feature properly unstable

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues.

Cc `@rust-lang/libs-api`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 3ce5d1d with merge 79200d6...

@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 3ce5d1d to 88960fd Compare December 13, 2024 18:10
@RalfJung
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
…_decodable, r=<try>

make rustc_encodable_decodable feature properly unstable

This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues.

Cc `@rust-lang/libs-api`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 88960fd with merge 09ea730...

@compiler-errors compiler-errors added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2024
@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: 09ea730 (09ea730c380b8b9acb96ff87b724c45df920f793)

@RalfJung
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-134272 created and queued.
🤖 Automatically detected try build 09ea730
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@RalfJung RalfJung force-pushed the destabilize-rustc_encodable_decodable branch from 88960fd to e9804a3 Compare December 14, 2024 10:04
@jhpratt
Copy link
Member

jhpratt commented Dec 14, 2024

I don't think there really was a plan — soft destabilizing it was the extent to which it was discussed afaik.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 14, 2024

There's some mixed messaging here: the ACP says "full destabilization is not proposed due to breakage of existing code", but the lint that is emitted when using these types says this "will become a hard error in a future release".

@jhpratt
Copy link
Member

jhpratt commented Dec 14, 2024

Ha, that's 100% on me. It must have been discussed on Zulip, as I wasn't aware soft destabilization was a thing before that. Anyways, it doesn't much matter.

@RalfJung
Copy link
Member Author

Well, seems like nobody complained about the future compat "this will become a hard error" warning that we have emitted for more than half a year now (and that is shown even when this occurs just in a dependency), so let's just see what crater says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants