-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make rustc_encodable_decodable feature properly unstable #134272
base: master
Are you sure you want to change the base?
make rustc_encodable_decodable feature properly unstable #134272
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
2993504
to
3ce5d1d
Compare
…_decodable, r=<try> make rustc_encodable_decodable feature properly unstable This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues. Cc `@rust-lang/libs-api`
This comment has been minimized.
This comment has been minimized.
3ce5d1d
to
88960fd
Compare
@bors try |
…_decodable, r=<try> make rustc_encodable_decodable feature properly unstable This has been shown in future-compat reports since Rust 1.79 (rust-lang#116016). Let's see if crater still finds any issues. Cc `@rust-lang/libs-api`
☀️ Try build successful - checks-actions |
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
88960fd
to
e9804a3
Compare
I don't think there really was a plan — soft destabilizing it was the extent to which it was discussed afaik. |
There's some mixed messaging here: the ACP says "full destabilization is not proposed due to breakage of existing code", but the lint that is emitted when using these types says this "will become a hard error in a future release". |
Ha, that's 100% on me. It must have been discussed on Zulip, as I wasn't aware soft destabilization was a thing before that. Anyways, it doesn't much matter. |
Well, seems like nobody complained about the future compat "this will become a hard error" warning that we have emitted for more than half a year now (and that is shown even when this occurs just in a dependency), so let's just see what crater says. |
This has been shown in future-compat reports since Rust 1.79 (#116016). Let's see if crater still finds any issues.
Cc @rust-lang/libs-api