de-stabilize bench attribute #134273
Open
de-stabilize bench attribute #134273
+16
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
S-waiting-on-review
|
Hm actually I guess this is more of a lang thing, sorry... Cc @rust-lang/lang |
RalfJung
added
T-lang
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
de-stabilize-bench
branch
from
a35de38 to
8e599b0
Compare
This comment has been minimized.
This comment has been minimized.
|
@ehuss what is the right thing to do with a lint that is not emitted any more by the compiler, but is kept around since it might be emitted again in the future? I don't think it makes sense to have an example in this lint, since we'll keep changing when the lint is emitted (as some soft-unstable items become real-unstable, and other stable items become soft-unstable). |
|
What you've done looks good to me. |
RalfJung
added
the
S-waiting-on-team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been soft-unstable since forever (#64066), and shown in future-compat reports since Rust 1.77 (#116274).
The feature covering
benchitself is tracked in #50297, which has been closed despite still having active feature gates referencing it.Cc @rust-lang/libs-api