-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Improve docs for mod 'result' #13499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//! | ||
//! Functions return `Result` whenever errors are expected and | ||
//! recoverable. In the `std` crate `Result` is most prominently used | ||
//! for [I/O](../io/index.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we had a way of cross linking docs the right way :(
This looks pretty awesome! |
I've addressed feedback, but left the two sections that @sfackler thought should go elsewhere. |
r=me with a nit and a rebase |
bors
added a commit
that referenced
this pull request
Apr 17, 2014
This adds some fairly extensive documentation for `Result`. I'm using manual links to other rustdoc html pages a bit.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 16, 2022
Fix `tt::Punct`'s spacing calculation Fixes rust-lang#13499 We currently set a `tt::Punct`'s spacing to `Spacing::Joint` unless its next token is a trivia (i.e. whitespaces or comment). As I understand it, rustc only [sets `Spacing::Joint` if the next token is an operator](https://github.com/rust-lang/rust/blob/5b3e9090757da9a95b22f589fe39b6a4b5455b96/compiler/rustc_parse/src/lexer/tokentrees.rs#L77-L78) and we should follow it to guarantee the consistent behavior of proc macros.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 7, 2024
…=xFrednet New lint `map_all_any_identity` This lint has been inspired by code encountered in Clippy itself (see the first commit). changelog: [`map_all_any_identity`]: new lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some fairly extensive documentation for
Result
.I'm using manual links to other rustdoc html pages a bit.