-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize float_next_up_down
#135661
Stabilize float_next_up_down
#135661
Conversation
FCP completed at [1]. Closes rust-lang#91399 [1]: rust-lang#91399 (comment)
Mention the IEEE function by name and create a doc alias of the same.
f4ecd9e
to
809f61a
Compare
Oh, nice to see these got FCP'd. I've done the hacky versions of them manually a few times for demos, so will be nice to be able to do it "properly". @bors r+ rollup |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133700 (const-eval: detect more pointers as definitely not-null) - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius) - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI) - rust-lang#135583 (Move `std::pipe::*` into `std::io`) - rust-lang#135612 (Include x scripts in tarballs) - rust-lang#135624 (ci: mirror buildkit image to ghcr) - rust-lang#135661 (Stabilize `float_next_up_down`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#135661 - tgross35:stabilize-float_next_up_down, r=scottmcm Stabilize `float_next_up_down` FCP completed at [1]. For `f16` and `f128`, this just removes the gates in comments and doctests. Closes rust-lang#91399 [1]: rust-lang#91399 (comment)
Updates required due to rust-lang/rust#135661
Same here, I decided to ask about FCP after copying the implementation to yet another place :) Thanks for reviewing! |
Changes required due to - rust-lang/rust#135344: Less unsafe in `dangling`/`without_provenance` - rust-lang/rust#135661: Stabilize `float_next_up_down` - rust-lang/rust#135709: Temporarily bring back `Rvalue::Len` Resolves: #3840 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
FCP completed at 1.
For
f16
andf128
, this just removes the gates in comments and doctests.Closes #91399