Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize float_next_up_down #135661

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jan 17, 2025

FCP completed at 1.

For f16 and f128, this just removes the gates in comments and doctests.

Closes #91399

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 17, 2025
Mention the IEEE function by name and create a doc alias of the same.
@tgross35 tgross35 force-pushed the stabilize-float_next_up_down branch from f4ecd9e to 809f61a Compare January 17, 2025 23:01
@scottmcm
Copy link
Member

Oh, nice to see these got FCP'd. I've done the hacky versions of them manually a few times for demos, so will be nice to be able to do it "properly".

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 18, 2025

📌 Commit 809f61a has been approved by scottmcm

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 18, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133700 (const-eval: detect more pointers as definitely not-null)
 - rust-lang#135290 (Encode constraints that hold at all points as logical edges in location-sensitive polonius)
 - rust-lang#135478 (Run clippy for rustc_codegen_gcc on CI)
 - rust-lang#135583 (Move `std::pipe::*` into `std::io`)
 - rust-lang#135612 (Include x scripts in tarballs)
 - rust-lang#135624 (ci: mirror buildkit image to ghcr)
 - rust-lang#135661 (Stabilize `float_next_up_down`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 23fb4f2 into rust-lang:master Jan 18, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2025
Rollup merge of rust-lang#135661 - tgross35:stabilize-float_next_up_down, r=scottmcm

Stabilize `float_next_up_down`

FCP completed at [1].

For `f16` and `f128`, this just removes the gates in comments and doctests.

Closes rust-lang#91399

[1]: rust-lang#91399 (comment)
@rustbot rustbot added this to the 1.86.0 milestone Jan 18, 2025
tautschnig added a commit to tautschnig/kani that referenced this pull request Jan 20, 2025
@tgross35
Copy link
Contributor Author

Oh, nice to see these got FCP'd. I've done the hacky versions of them manually a few times for demos, so will be nice to be able to do it "properly".

Same here, I decided to ask about FCP after copying the implementation to yet another place :) Thanks for reviewing!

@tgross35 tgross35 deleted the stabilize-float_next_up_down branch January 20, 2025 19:46
github-merge-queue bot pushed a commit to model-checking/kani that referenced this pull request Jan 22, 2025
Changes required due to
- rust-lang/rust#135344: Less unsafe in `dangling`/`without_provenance`
- rust-lang/rust#135661: Stabilize `float_next_up_down`
- rust-lang/rust#135709: Temporarily bring back `Rvalue::Len`

Resolves: #3840

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for float_next_up_down
4 participants