Change collect_and_partition_mono_items tuple return type to a struct
#136118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
|
r? compiler |
Zalathar
reviewed
Jan 27, 2025
| @@ -247,6 +247,12 @@ impl ToStableHashKey<StableHashingContext<'_>> for MonoItem<'_> { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, HashStable, Copy, Clone)] | |||
| pub struct CodegenUnits<'tcx> { | |||
There was a problem hiding this comment.
Nitpick: Calling this CodegenUnits seems slightly weird, since it contains both codegen_units and associated global info that is not codegen units.
(For a struct that exists to be returned by a single query, my first thought would have been to name it something boring derived from the name of the query.)
There was a problem hiding this comment.
yea... I couldn't come up with anything so I used that. MonoItemPartitions maybe?
|
I have reservations about the struct name, but otherwise I'm very happy to see this change. I remember being annoyed that it hadn't been done already. |
oli-obk
force-pushed
the
push-qsslxsopnrmr
branch
2 times, most recently
from
6dfd0e2 to
479268b
Compare
Zalathar
reviewed
Jan 27, 2025
|
Cool, thanks. Feel free to r=me. |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
push-qsslxsopnrmr
branch
from
479268b to
b24f674
Compare
|
@bors r=Zalathar |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#135773 (Clarify WindowsMut (Lending)Iterator) - rust-lang#135807 (Implement phantom variance markers) - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135988 (Add a workaround for parallel rustc crashing when there are delayed bugs) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136064 (Add a suggestion to cast target_feature fn items to fn pointers.) - rust-lang#136082 (Incorporate `iter_nodes` into `graph::DirectedGraph`) - rust-lang#136112 (Clean up all dead files inside `tests/ui/`) - rust-lang#136114 (Use identifiers more in diagnostics code) - rust-lang#136118 (Change `collect_and_partition_mono_items` tuple return type to a struct) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup merge of rust-lang#136118 - oli-obk:push-qsslxsopnrmr, r=Zalathar Change `collect_and_partition_mono_items` tuple return type to a struct rust-lang#133429 will add a new field to this tuple, so it seems prudent to turn it into a struct first to avoid confusion about what the tuple elements mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133429 will add a new field to this tuple, so it seems prudent to turn it into a struct first to avoid confusion about what the tuple elements mean.