Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Atomic<T> type alias (rebase) #136316

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jan 30, 2025

Rebase of #130543.

Additional changes:

  • Switch from allow to expect for private_bounds on AtomicPrimitive
  • Unhide AtomicPrimitive::AtomicInner from docs, because rustdoc shows the definition pub type Atomic<T> = <T as AtomicPrimitive>::AtomicInner; and generated links for it.
    • NonZero did not have this issue, because they kept the new alias private before the direction was changed.
  • Use Atomic<_> in more places, including inside Once's Futex. This needs some changes in clippy:
    • Make clippy properly resolve things like <T as Trait>::Assoc during interior mutability analysis.

Clippy changes will go through their upstream repo: rust-lang/rust-clippy#14125.
Blocked on that for now.
@rustbot label +S-blocked -S-waiting-on-review

The rest will either get moved back to #130543 or #130543 will be closed in favor of this instead.

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-unix Operating system: Unix-like O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 30, 2025
@GrigorenkoPV GrigorenkoPV changed the title Create Atomic<T> type alias (rebase of #130543) Create Atomic<T> type alias (rebase) Jan 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2025

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ChrisDenton ChrisDenton removed their assignment Jan 31, 2025
@ChrisDenton
Copy link
Member

I've removed myself from the assigned reviewer for now but feel free to assign to me again (or r? libs) when you're ready.

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025
@bors
Copy link
Contributor

bors commented Feb 6, 2025

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-unix Operating system: Unix-like O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants