-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Atomic<T>
type alias (rebase)
#136316
base: master
Are you sure you want to change the base?
Conversation
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
Atomic<T>
type alias (rebase)
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
b55c4f2
to
3d63489
Compare
This comment has been minimized.
This comment has been minimized.
I've removed myself from the assigned reviewer for now but feel free to assign to me again (or |
in core/alloc/std only for now, and ignoring test files Co-authored-by: Pavel Grigorenko <[email protected]>
04dc387
to
db4a587
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebase of #130543.
Additional changes:
allow
toexpect
forprivate_bounds
onAtomicPrimitive
AtomicPrimitive::AtomicInner
from docs, because rustdoc shows the definitionpub type Atomic<T> = <T as AtomicPrimitive>::AtomicInner;
and generated links for it.NonZero
did not have this issue, because they kept the new alias private before the direction was changed.Atomic<_>
in more places, including insideOnce
'sFutex
. This needs some changes in clippy:<T as Trait>::Assoc
during interior mutability analysis.Clippy changes will go through their upstream repo: rust-lang/rust-clippy#14125.
Blocked on that for now.
@rustbot label +S-blocked -S-waiting-on-review
The rest will either get moved back to #130543 or #130543 will be closed in favor of this instead.