Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap compiler and rustfmt #136751

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 8, 2025

The rustfmt version we previously used formats things differently from what the latest nightly rustfmt does. This causes issues for subtrees that get formatted both in-tree and in their own repo. Updating the rustfmt used in-tree solves those issues. Also bumped the bootstrap compiler as the stage0 update command always updates both at the same
time.

The rustfmt version we previously used formats things differently from
what the latest nightly rustfmt does. This causes issues for subtrees
that get formatted both in-tree and in their own repo. Updating the
rustfmt used in-tree solves those issues. Also bumped the bootstrap
compiler as the stage0 update command always updates both at the same
time.
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Feb 8, 2025

📌 Commit 1fcae03 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 8, 2025
@oli-obk oli-obk assigned Mark-Simulacrum and unassigned oli-obk Feb 9, 2025
@bors
Copy link
Contributor

bors commented Feb 9, 2025

⌛ Testing commit 1fcae03 with merge 124cc92...

@bors
Copy link
Contributor

bors commented Feb 9, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 124cc92 to master...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (124cc92): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Max RSS (memory usage)

Results (primary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

Results (primary 2.8%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 2.8% [2.8%, 2.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.631s -> 779.273s (0.21%)
Artifact size: 329.11 MiB -> 329.09 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Feb 9, 2025
@bjorn3 bjorn3 deleted the update_rustfmt branch February 9, 2025 20:32
@lqd
Copy link
Member

lqd commented Feb 9, 2025

syn is bimodal rn @rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 10, 2025
…=compiler-errors

Git blame ignore recent formatting commit

This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 10, 2025
…=compiler-errors

Git blame ignore recent formatting commit

This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Rollup merge of rust-lang#136790 - ehuss:ignore-rustfmt-2024-again, r=compiler-errors

Git blame ignore recent formatting commit

This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants