-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap compiler and rustfmt #136751
Conversation
The rustfmt version we previously used formats things differently from what the latest nightly rustfmt does. This causes issues for subtrees that get formatted both in-tree and in their own repo. Updating the rustfmt used in-tree solves those issues. Also bumped the bootstrap compiler as the stage0 update command always updates both at the same time.
@bors r+ p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (124cc92): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.8%, secondary -2.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.631s -> 779.273s (0.21%) |
syn is bimodal rn @rustbot label: +perf-regression-triaged |
…=compiler-errors Git blame ignore recent formatting commit This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
…=compiler-errors Git blame ignore recent formatting commit This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
Rollup merge of rust-lang#136790 - ehuss:ignore-rustfmt-2024-again, r=compiler-errors Git blame ignore recent formatting commit This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
The rustfmt version we previously used formats things differently from what the latest nightly rustfmt does. This causes issues for subtrees that get formatted both in-tree and in their own repo. Updating the rustfmt used in-tree solves those issues. Also bumped the bootstrap compiler as the stage0 update command always updates both at the same
time.