syntax: Make quasiquoter use absolute paths #14626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of removing `pub use` glob, two extra import globs were injected to make `quote_expr!` work. However the globs caused `unused_import` warning in some places. Quasiquoter needed the globs since it generated idents (e.g. `TyU`) rather than absolute paths (`::syntax::ast::TyU`). This patch removes the extra globs and makes quasiquoter use absolute paths. Fixes rust-lang#14618
bors
added a commit
that referenced
this pull request
Jun 3, 2014
As part of removing `pub use` glob, two extra import globs were injected to make `quote_expr!` work. However the globs caused `unused_import` warning in some places. Quasiquoter needed the globs since it generated idents (e.g. `TyU`) rather than absolute paths (`::syntax::ast::TyU`). This patch removes the extra globs and makes quasiquoter use absolute paths. Fixes #14618 cc @sfackler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
feat: Assist to replace generic with impl trait
This adds a new assist named "Replace named generic with impl". It is the inverse operation to the existing "Replace impl trait with generic" assist.
It allows to refactor the following statement:
```rust
// 👇 cursor
fn new<T$0: ToString>(input: T) -> Self {}
```
to be transformed into:
```rust
fn new(input: impl ToString) -> Self {}
```
* adds new helper function `impl_trait_type` to create AST node
* add method to remove an existing generic param type from param list
Closes rust-lang#14626
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Fix Assist "replace named generic type with impl trait" This is a follow-up PR to fix the assist "replace named generic type with impl trait" described in rust-lang#14626 to filter invalid param types. It integrates the feedback given in PR rust-lang#14816 . The change updates the logic to determine when a function parameter is safe to replace a type param with its trait implementation. Some parameter definitions are invalid & should not be replaced by their traits, therefore skipping the assist completely. First, all usages of the generic type under the cursor are determined. These usage references are checked to see if they occur outside the function parameter list. If an outside reference is found, e.g. in body, return type or where clause, the assist is skipped. All remaining usages need to appear only in the function param list. For each usage the param type is further inspected to see if it's valid. The logic to determine if a function parameter is valid, follows a heuristic and may not cover all possible parameter definitions. With this change the following param types (as given in [this comment](rust-lang/rust-analyzer#14816 (comment))) are not replaced & therefore skip the assist. ```rust fn foo<P: Trait>( _: <P as Trait>::Assoc, // within path type qualifier _: <() as OtherTrait<P>>::Assoc, // same as above _: P::Assoc, // associated type shorthand _: impl OtherTrait<P> // generic arg in impl trait (note that associated type bindings are fine) _: &dyn Fn(P) // param type and/or return type for Fn* traits ) {} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of removing
pub useglob, two extra import globs wereinjected to make
quote_expr!work. However the globs causedunused_importwarning in some places.Quasiquoter needed the globs since it generated idents (e.g.
TyU)rather than absolute paths (
::syntax::ast::TyU).This patch removes the extra globs and makes quasiquoter use absolute
paths.
Fixes #14618
cc @sfackler