Add --color to test binary options #14760
Conversation
|
I'm a little worried about enabling this for all concurrency levels. We capture the test task's output, but we don't capture the sub-tasks of those tasks. For example, synctest spawns tons of tasks and almost none of the output is captured. Other than that, though, this looks good to me. |
|
Subtasks don't inherit their supertask's IO sources? |
|
Not currently, but I would like them to! |
|
Want me to add back the concurrency level check to the AutoColor logic until then? Colorized output is so nice though :( |
|
r=me if you bring back the check for |
|
Is there an issue for IO inheritance? |
|
Not that I know of. My idea was to have a set of cloneable task local data, but I'm not sure how well that will pan out. |
sfackler
changed the title
|
Travis failed. |
| task, allow printing directly")) | ||
| task, allow printing directly"), | ||
| getopts::optopt("", "color", "Configure coloring of output: | ||
| auto = colorize if stdout is a tty and tests are run on serially (default); |
There was a problem hiding this comment.
Do you mean for this to be indented 12 spaces in the final output?
There was a problem hiding this comment.
It's not. Getopts strips newlines, looks like.
It uses the same behavior as rustc's.
Closes #14611 (std: Remove the as_utf16_p functions) Closes #14694 (Num cleanup) Closes #14760 (Add --color to test binary options) Closes #14763 (std: Move dynamic_lib from std::unstable to std) Closes #14766 (Add test for issue #13446) Closes #14769 (collections: Add missing Default impls) Closes #14773 (General nits) Closes #14776 (rustdoc: Correctly classify enums/typedefs)
minor: Hide deps panel outside of Rust projects and set missing category Closes rust-lang#14760
No description provided.