std: Don't fail the task when a Future is dropped #14941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Make sure the future didn't fail the task. | ||
| assert_eq!(unsafe { FOO.load(atomics::SeqCst) }, 1); |
There was a problem hiding this comment.
Clever use of TLS. I didn't realize you could use it that way to find out if the task exited due to failure or not.
Seems to me you can skip the atomics though, and just use a separate channel. Have Bomb send task::failing() across a channel and read it on the other side.
There was a problem hiding this comment.
Sounds like a good idea!
It's a benign failure that no one needs to know about. Closes rust-lang#14892
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Shrink `DefMap`, share crate level items with block def maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a benign failure that no one needs to know about.
Closes #14892