doc: a few minor style fixes #16241
Merged
doc: a few minor style fixes #16241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! is just a pointer. Tree-like data structures are often built on owned | ||
| //! pointers because each node often has only one owner, the parent. | ||
| //! is the same as that of a pointer. Tree-like data structures are often built | ||
| //! on owned pointers because each node often has only one owner, the parent. |
There was a problem hiding this comment.
"owned pointers" is no longer a thing, I would say
Tree-like data structures are often build with boxes because each node has only one owner, the parent.
|
Wow, what a diff. Thank you so much. |
|
ping @P1start, is this ready to go with a rebase? |
|
@alexcrichton Rebased. This should be good to go now. |
|
This is a massive diff, and I'm on a plane all day today. It looks like my concerns were all addressed, so if you're happy, @alexcrichton , then yes, r=me. Otherwise, I can re-read the entire diff again in a day or two. |
bors
added a commit
that referenced
this pull request
Aug 19, 2014
For crates `alloc`–`collections`. This is mostly just updating a few function/method descriptions to use the indicative style. cc #4361; I’ve sort of assumed that the third-person indicative style has been decided on, but I could update this to use the imperative style if that’s preferred, or even update this to remove all function-style-related changes. (I think that standardising on one thing, even if it’s not the ‘best’ option, is still better than having no standard at all.) The indicative style seems to be more common in the Rust standard library at the moment, especially in the newer modules (e.g. `collections::vec`), more popular in the discussion about it, and also more popular amongst other languages (see #4361 (comment)).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
Give a userful error when rustc cannot be found in explicit sysroot Somehow r-a believed that my sysroot was something weird with no rustc. Probably a me issue, but it was impossible to diagnose since r-a just gave me a plain "No such file or directory". Adding this error makes it clear what happened and allows diagnosing the problem.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For crates
alloc–collections. This is mostly just updating a few function/method descriptions to use the indicative style.cc #4361; I’ve sort of assumed that the third-person indicative style has been decided on, but I could update this to use the imperative style if that’s preferred, or even update this to remove all function-style-related changes. (I think that standardising on one thing, even if it’s not the ‘best’ option, is still better than having no standard at all.) The indicative style seems to be more common in the Rust standard library at the moment, especially in the newer modules (e.g.
collections::vec), more popular in the discussion about it, and also more popular amongst other languages (see #4361 (comment)).