Avoid creating cyclic types during inference #17157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detecting them in resolve. This simplifies logic elsewhere in the compiler. cc rust-lang#5527
| let f; | ||
| let g; | ||
| g = f; | ||
| f = box(GC) g; //~ ERROR cyclic type of infinite size |
There was a problem hiding this comment.
sigh I really wish we would stop accumulating tests using @T aka Gc<T>.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 19, 2024
fix: Don't retry position relient requests and version resolve data Fixes rust-lang/rust-analyzer#15907 Fixes rust-lang/rust-analyzer#14839 Fixes rust-lang/rust-analyzer#16536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid ever constructing cyclic types in the first place, rather than detecting them in resolve. This simplifies logic elsewhere in the compiler, in particular on the trait reform branch.
r? @pnkfelix or @pcwalton
cc #5527