Add to_c_str_opt/with_c_str_opt functions and fix an ICE #17435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ese functions return an Option if the string they are passed contains a null byte, rather than failing the task like to_c_str/with_c_str. Updated get_item_val in middle/trans/base to use these functions to fix the ICE in issue #16478
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
|
|
|
@kaseyc Thanks for this PR! Unfortunately, the question of whether/when to provide such For the time being, could you instead fix the ICE by having the rustc code check for nulls itself, in advance of calling |
|
Not a problem. Thanks! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…ykril docs: fix manual generation instructions To generate all the requisite files, you need to run `cargo xtask codegen` not `cargo test -p xtask`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to_c_str_opt and with_c_str_opt functions to the ToCStr trait. These functions return an Option if the string they are passed contains a null byte, rather than failing the task like to_c_str/with_c_str.
Updated get_item_val in middle/trans/base to use these functions to fix the ICE in issue #16478.
Fixes #16478