alloc: fix reallocate_inplace implementation #17705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be tested? I don't think there are currently any users of this, and it'd be nice to have at least a smoke test. |
|
The can't really be tested without hard-wiring an assumption about when jemalloc can do an in-place resize. |
|
Oh ok, one other question I just realized, if the returned size is the new size, this looks like it will return false if Could that be deterministically tested as well? |
The returned size is the new real size of the allocation.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 2, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
feat: Use oldest rustup rust-analyzer when toolchain override is present Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole. In terms of precedence: nightly > stable-with-version > stable With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win. Fixes rust-lang#17663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned size is the new real size of the allocation.