Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of deriving with derive in docs #20632

Merged
merged 1 commit into from
Jan 16, 2015
Merged

Conversation

gchp
Copy link
Contributor

@gchp gchp commented Jan 6, 2015

I noticed that the deriving keyword is deprecated and that derive is the replacement. This updates the reference (and other docs) to remove the use deriving.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@huonw
Copy link
Member

huonw commented Jan 6, 2015

r? @steveklabnik

@frewsxcv
Copy link
Member

frewsxcv commented Jan 9, 2015

Needs a rebase

@gchp
Copy link
Contributor Author

gchp commented Jan 9, 2015

Updated with changes from master.

@frewsxcv
Copy link
Member

Needs another one :)

@gchp
Copy link
Contributor Author

gchp commented Jan 13, 2015

Not sure why all those extra commits are showing up here...sorry about that.

@steveklabnik
Copy link
Member

Try rebasing off of the current master and force-pushing to this branch.

@gchp
Copy link
Contributor Author

gchp commented Jan 13, 2015

@steveklabnik cool, that did it!

@steveklabnik
Copy link
Member

Great, thanks!

bors added a commit that referenced this pull request Jan 14, 2015
Replace usage of deriving with derive in docs

Reviewed-by: steveklabnik
bors added a commit that referenced this pull request Jan 14, 2015
Replace usage of deriving with derive in docs

Reviewed-by: steveklabnik
bors added a commit that referenced this pull request Jan 15, 2015
Replace usage of deriving with derive in docs

Reviewed-by: steveklabnik
bors added a commit that referenced this pull request Jan 15, 2015
Replace usage of deriving with derive in docs

Reviewed-by: steveklabnik
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 15, 2015
I noticed that the `deriving` keyword is deprecated and that `derive` is the replacement. This updates the reference (and other docs) to remove the use `deriving`.
@bors bors merged commit 4b14f67 into rust-lang:master Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants