Remove unused import. #20976
Merged
Remove unused import. #20976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Was this giving a compilation warning and-or have you tested that this doesn't break anything? (worried about spooky trait import action at-a-distance) |
|
I saw a compilation warning when I did a full rebuild on libcollections, including tests and benchmarks. It looks like the unused import is only defined in the tests so I'm not sure there would be an impact elsewhere. But I'm a novice with the module system so I could be wrong. |
|
If the compiler said it was unused, I'm liable to trust it. |
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Remove unused import. Reviewed-by: Gankro
bors
referenced
this pull request
Jan 14, 2015
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Remove unused import. Reviewed-by: Gankro
bors
referenced
this pull request
Jan 15, 2015
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Remove unused import. Reviewed-by: Gankro
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Remove unused import. Reviewed-by: Gankro
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 15, 2015
The BorrowFrom trait was unused by the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BorrowFrom trait was unused by the tests.