Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r+] Windows building fixes #21046

Merged
merged 2 commits into from
Jan 16, 2015
Merged

[r+] Windows building fixes #21046

merged 2 commits into from
Jan 16, 2015

Conversation

steveklabnik
Copy link
Member

These should help out with the in-tree parts of #16654

This is much more helpful.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -67,7 +67,9 @@ To easily build on windows we can use [MSYS2](http://sourceforge.net/projects/ms
$ pacman -S mingw-w64-i686-toolchain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mention mingw-w64-x86_64-toolchain for people trying to use 64-bit Rust.

@alexcrichton
Copy link
Member

r=me with @retep998's suggestion

bors added a commit that referenced this pull request Jan 14, 2015
Windows building fixes

Reviewed-by: alexcrichton
@nikomatsakis nikomatsakis changed the title Windows building fixes [r+] Windows building fixes Jan 14, 2015
bors added a commit that referenced this pull request Jan 14, 2015
[r+] Windows building fixes

Reviewed-by: alexcrichton
bors added a commit that referenced this pull request Jan 15, 2015
[r+] Windows building fixes

Reviewed-by: alexcrichton
bors added a commit that referenced this pull request Jan 15, 2015
[r+] Windows building fixes

Reviewed-by: alexcrichton
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 15, 2015
These should help out with the in-tree parts of rust-lang#16654
@bors bors merged commit 5992325 into rust-lang:master Jan 16, 2015
@steveklabnik steveklabnik deleted the gh16654 branch October 25, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants