[r+] Intpocalypse, book edition. #21096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with respect to the choice of reviewer: No good deed goes unpunished. |
|
@nikomatsakis ❤️ 😅 |
| // error: mismatched types: expected `core::option::Option<f64>` | ||
| // but found `core::option::Option<int>` (expected f64 but found int) | ||
| // but found `core::option::Option<i32>` (expected f64 but found i32) |
There was a problem hiding this comment.
This should be
error: mismatched types: expected core::option::Option, found core::option::Option<_> (expected f64, found integral variable)
steveklabnik
force-pushed
the
intpocalypse
branch
from
80e8f95 to
45e01b4
Compare
bors
referenced
this pull request
Jan 14, 2015
steveklabnik
force-pushed
the
intpocalypse
branch
from
45e01b4 to
b290fbe
Compare
nikomatsakis
changed the title
steveklabnik
force-pushed
the
intpocalypse
branch
from
b290fbe to
180efcc
Compare
| fn add_one(x: &int) -> int { | ||
| ======= |
steveklabnik
force-pushed
the
intpocalypse
branch
from
180efcc to
d3300c0
Compare
bors
referenced
this pull request
Jan 17, 2015
bors
referenced
this pull request
Jan 17, 2015
Fix all usage of int/uint/i/u in the book.
steveklabnik
force-pushed
the
intpocalypse
branch
from
d3300c0 to
59c75e5
Compare
|
This made it in as part of my rolllup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all usage of int/uint/i/u in the book.
r? @nikomatsakis who called this to my attention.