Improve the error message when source file cannot be read #21336
Conversation
Contribution from @look!
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Improve the error message when source file cannot be read Reviewed-by: brson
Improve the error message when source file cannot be read Reviewed-by: brson
Contribution from @look! Addresses rust-lang#21329
Contribution from @look! Addresses rust-lang#21329
|
@bors: r- |
|
This has a failing test in the rollup: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3222/steps/test/logs/stdio |
| path.display(), | ||
| e)[]); | ||
| error_msg)[]); |
There was a problem hiding this comment.
I think this should actually continue to format e entirely, it should just use {} instead of {:?}
|
Either this got accidentally merged, or #21329 can be closed. |
Contribution from @look!
Addresses #21329