stage info #26599
stage info #26599
Conversation
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson I don't have too much of an opinion on this, but I think you might! |
|
I understand the use case, but I feel a little uneasy about it. It's a niche feature for rustc hackers. I want to think about it a bit more and see if others comment. |
|
@brson I am of two minds as a rustc hacker I think it is kind of useful, but I don't know really think we should leak this information to all users of the Rust compiler given its irrelevant to 99% of our users. I tend to just use the stage1 inside the tree so it is possible I don't have the best perspective. |
|
How about just leaving it out for stage2+ ? That would seem to make it transparent to end users, but make it visible if you're poking a bootstrap compiler while hacking? |
|
☔ The latest upstream changes (presumably #26631) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@richo Ok, let's add it for stage0/1. Thanks for your patience. |
|
No worries! I'll update this when I get a sec :) |
richo
force-pushed
the
richo-stage-info
branch
2 times, most recently
from
18b7ad5 to
8ab76af
Compare
|
Updated! r? @brson |
|
@bors r+ rollup |
|
📌 Commit e66ac43 has been approved by |
|
I'm not really sure what's going on, but the stage2 build (including the assets installed by I think this patch is still good to land, but it seems something is askew here. |
This will add information about the stage that a rustc was built with to the verbose version info
I have symlinks into $(HOST)/stage{0,1,2} into the rust version switcher thing I use, and occasionally need to know which stage a given rustc is.
This will add information about the stage that a rustc was built with to the verbose version info
I have symlinks into $(HOST)/stage{0,1,2} into the rust version switcher thing I use, and occasionally need to know which stage a given rustc is.
This will add information about the stage that a rustc was built with to the verbose version info
I have symlinks into $(HOST)/stage{0,1,2} into the rust version switcher thing I use, and occasionally need to know which stage a given rustc is.
This will add information about the stage that a rustc was built with to the verbose version info
I have symlinks into $(HOST)/stage{0,1,2} into the rust version switcher thing I use, and occasionally need to know which stage a given rustc is.
This reverts #26599, which puts the stage number in the output of `--version -v`, but is not supposed to put it in the 'stage2' compiler, which is what most people refer to the binary we deploy. The picture is not so clear though because of how stage 'promotions' happen in the build and also because the windows build deploys stage3, not stage2. cc @richo
This will add information about the stage that a rustc was built with to the verbose version info
I have symlinks into $(HOST)/stage{0,1,2} into the rust version switcher thing I use, and occasionally need to know which stage a given rustc is.