Cleanup ty decoder #27851
Merged
Cleanup ty decoder #27851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to store the closure in the PSState struct
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
oh, one more commit coming. |
|
ok. |
| parse_ty_data(tp.data, cdata.cnum, tp.start, tcx, | ||
| |_, did| translate_def_id(cdata, did)) | ||
| TyDecoder::with_doc(tcx, cdata.cnum, tp, | ||
| &mut |_, did| translate_def_id(cdata, did)) |
There was a problem hiding this comment.
Couldn't this be created by a method on cdata, providing the translation function to TyDecoder?
There was a problem hiding this comment.
@eddyb hmm perhaps -- it's a bit tricky to get lifetime of the closure to work out I think, but I guess now that the closure is stored in a struct, we could give ownership of it instead of passing an &mut. Would be kind of nicer anyway. Maybe I should do that.
|
@bors r+ |
|
📌 Commit 7a3a1be has been approved by |
bors
added a commit
that referenced
this pull request
Aug 16, 2015
Just a little code cleanup I was doing as part of another refactoring (which may turn out not to be needed). The main thrust of this is to cleanup the interface to `tydecode.rs` to be less ridiculously repetitive. I also purged the generic "def-id conversion" parameter in favor of a trait object, just to reduce code duplication a bit and make the signatures a bit less messy. I measured the bootstrapping time to build stage2 with these changes, it was identical. (But it'd be easy enough to restore the unboxed closure if we wanted it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little code cleanup I was doing as part of another refactoring (which may turn out not to be needed). The main thrust of this is to cleanup the interface to
tydecode.rsto be less ridiculously repetitive. I also purged the generic "def-id conversion" parameter in favor of a trait object, just to reduce code duplication a bit and make the signatures a bit less messy. I measured the bootstrapping time to build stage2 with these changes, it was identical. (But it'd be easy enough to restore the unboxed closure if we wanted it.)