Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-crate foreign function usage #2835

Closed
wants to merge 33 commits into from
Closed

Fix cross-crate foreign function usage #2835

wants to merge 33 commits into from

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Jul 7, 2012

This is a brand new area for me, so scrutinize well.

msullivan and others added 18 commits July 6, 2012 15:04
@msullivan
Rip out a bunch more append code from trans.
9e6b43f
@brson
tutorial: Reduce header level for do/for loop sections
fce064d
@eholk
Added a k-nucleotide version that uses pipes. 31% speedup.
b925648
@eholk
Bank protocol example from blog post
e20f63d
@graydon
For rust-lang#2229, recognize 'again' in place of 'cont', final chang…
ceac155 
…e pending snapshot.
@msullivan
Be less eager about implicit borrowing when doing method resolution. C…
038f925 
…loses rust-lang#2796.
@msullivan
Fix the indenter script to know about the annoying ~ in the front of …
23c7336 
…log strings.
@graydon
First step on rust-lang#2826, accept ^ for ty_ptr.
6b8ebc1
@brson
tutorial: Remove some trivia
57698fe
@brson
Add 'class' and 'new' to codemirror-rust.js
4bb13c6
@brson
tutorial: Fix a test-breaking typo
ad05996
@brson
tutorial: Expand the section on datatypes
af199f2
@brson
tutorial: Add some work on borrowed pointers
28fec95
@brson
tutorial: Use consistent casing in headers
b5f5676
@pcwalton
rustc: Switch to the new resolution pass
c4af6e9
@bblum
change borrowck error msg: 'declared in outer block' -> 'captured in …
b5b8f5e 
…a closure'
@bblum
vim: hilight option, either, libc types+constants
f9cb04f
@nikomatsakis
Revert "rustc: Switch to the new resolution pass"
a856bcc 
This reverts commit c4af6e9.

Branch was burning...many, many unresolved imports.
@brson
Copy link
Contributor

brson commented Jul 7, 2012

This looks right, except for the possibly redundant if branch. Please add a test case to the run-pass directory. You can probably base it off of run-pass/extern-call.rs, using the aux-build directive to put the extern functions into a different crate.

@jdm
Copy link
Contributor Author

jdm commented Jul 9, 2012

Changes made. Github is silly and doesn't make any noise without further comments.

@brson
Copy link
Contributor

brson commented Jul 9, 2012

Pushed to incoming.

@brson brson closed this Jul 9, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Apr 28, 2023
@bors
Auto merge of rust-lang#2835 - saethlin:rustup, r=oli-obk
2c45553 
rustup

`@oli-obk` I think this is the resolution we agreed to on Zulip?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jdm @brson @msullivan @eholk @graydon @pcwalton @bblum @nikomatsakis