Adding simple net::url module to parse and format urls. As per Issue #2661. #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It may take a few days to review this as we're currently wrapping up the 0.3 release. |
|
This is great. We should pull this and erickt's code into libstd. I'll test and land, thanks! |
|
Should I merge in erickt's code to this pull request (and is there a way to add him to this conversation so I can ask him if I can do that? sorry, new to github), or add it in after this lands? |
|
@dbp: Sure, feel free to merge away in this commit or a separate pull request :) |
|
Integrated (with slight fixes for drift). Thanks! |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 28, 2023
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 30, 2023
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
We override a few std functions to improve verification time or verification results, however, those functions are quite helpful during concrete execution. Thus, avoid overriding functions when executing concrete playback. Resolves rust-lang#2850 Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does basic parsing and formatting of urls. I wrote it based on #2661 .
It does not do url encoding/decoding, which hopefully could be integrated from https://github.com/erickt/rust-uri (the main reason I didn't write it).
It also does barely any validation, mainly because this is my first time writing rust code and I wanted to make sure that it looked alright before making the library too complicated. The main thing that I wanted to get with this initial stab was the external interface - the types and function signatures. The test cases should reflect this limitation - they only test valid urls.
The library is designed to be used qualified (ie, url::to_str, url::from_str), though if that is not the proper style, it can easily be changed.
Either way - feedback is welcome (on style, interface, correctness, etc).