-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessors for Formatter flags #28615
Conversation
@bors: r+ There's probably an argument to be made that libc shouldn't expose any functions at all on Windows. (The crate wouldn't be completely empty because it would contain some types.) It might be a good idea to explicitly exclude pure math functions from the scope of libc (sin(), abs(), etc.). They aren't necessary, and we'd end up either reimplementing a lot of them in Rust or randomly excluding them on various platforms. |
📌 Commit e5ee13f has been approved by |
Oops, that was the wrong thing to copy paste At least bors got the right idea! |
💔 Test failed - auto-linux-32-opt |
@bors retry |
⚡ Previous build results for auto-mac-32-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
cc #27726
r? @alexcrichton