Implement compare_exchange and compare_exchange_weak #30969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Amanieu
force-pushed
the
extended_atomic_cmpxchg
branch
4 times, most recently
from
841b5ac to
93b5e82
Compare
|
Just noting that this is not an accepted RFC, so not reviewing yet. |
Amanieu
force-pushed
the
extended_atomic_cmpxchg
branch
from
93b5e82 to
c59950f
Compare
Amanieu
changed the title
|
I've updated the implementation to match the accepted RFC. |
| /// `compare_exchange` takes two `Ordering` arguments to describe the memory ordering | ||
| /// of this operation. The first describes the required ordering if the operation succeeds while | ||
| /// the second describes the required ordering when the operation fails. The failure ordering | ||
| /// can't be `Acquire` or `AcqRel` and must be equivalent or weaker than the success ordering. |
There was a problem hiding this comment.
Could you wrap these comments to 80 chars? (the surrounding style)
There was a problem hiding this comment.
Actually the surrounding style seems to wrap comments at 100 chars, which is what I've been using.
|
Thanks @Amanieu! |
Amanieu
force-pushed
the
extended_atomic_cmpxchg
branch
from
c59950f to
b4b2a25
Compare
|
Updated with comments addressed |
|
Thanks! Just to ensure that we've got all code paths covered, could you make sure that there's at least some call to each cmpxchg instrinsic in the tests? Just to make sure that trans doesn't choke on accident from any of these. |
|
Done |
bors
added a commit
that referenced
this pull request
Feb 22, 2016
This is an implementation of rust-lang/rfcs#1443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of rust-lang/rfcs#1443.