Don't assume color=always when explicitally specified #31550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @nrc |
|
Note: I haven't actually tested this change because rust takes an eternity to build on my poor old laptop. However, I don't expect it to fail (famous last words...). |
|
|
||
| Some(arg) => { | ||
| early_error(ErrorOutputType::default(), &format!("argument for --error-format must \ | ||
| early_error(ErrorOutputType::HumanReadable(color), &format!("argument for --error-format must \ |
| early_error(ErrorOutputType::HumanReadable(color), | ||
| &format!("argument for --error-format must \ | ||
| be human or json (instead was \ | ||
| `{}`)", |
There was a problem hiding this comment.
nit: this can squeeze on the previous line.
|
r+ with the style nit addressed |
|
@bors: r+ |
|
📌 Commit 03ef55b has been approved by |
|
Thanks for the quick fix @Stebalien! Nominating for backport as well |
alexcrichton
added
the
beta-nominated
|
Can we test this somehow to prevent future regressions? Maybe with a run-make test that greps for \x1b or something? |
bors
added a commit
that referenced
this pull request
Feb 12, 2016
pnkfelix
added
the
E-needs-test
nikomatsakis
added
T-compiler
|
Accepting for beta since seems awfully minor. |
|
cc @rust-lang/compiler |
|
+1 |
Merged
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31546