Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer necessary coercions to fn pointer types. #32612

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

frewsxcv
Copy link
Member

Originally added in 8fe9e4d.

Everything appears to build fine without the coercions, so they can
presumably be removed.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv force-pushed the unnecessary-coercions branch 2 times, most recently from 49976aa to 7559a3a Compare March 30, 2016 13:44
@frewsxcv
Copy link
Member Author

cc @nikomatsakis (since you were the author of 8fe9e4d)

Originally added in 8fe9e4d.

Everything appears to build fine without the coercions, so they can
presumably be removed.
@frewsxcv frewsxcv force-pushed the unnecessary-coercions branch from 7559a3a to 99501e6 Compare March 30, 2016 13:50
@alexcrichton
Copy link
Member

@bors: r+ 99501e6

Nice!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 30, 2016
…lexcrichton

Remove no longer necessary coercions to fn pointer types.

Originally added in 8fe9e4d.

Everything appears to build fine without the coercions, so they can
presumably be removed.
bors added a commit that referenced this pull request Mar 30, 2016
Rollup of 4 pull requests

- Successful merges: #32259, #32494, #32612, #32618
- Failed merges: #32562
@bors bors merged commit 99501e6 into rust-lang:master Mar 31, 2016
@frewsxcv frewsxcv deleted the unnecessary-coercions branch March 31, 2016 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants