Update error format for E0062 #35328
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Just to confirm - this may be related to the "span_labels not shown in old school mode" problem (#35330) people are experiencing, but that issue shouldn't block this PR. I'm investigating. |
|
@bors r+ rollup |
|
📌 Commit 0214ec2 has been approved by |
…turner Update error format for E0062 Fixes rust-lang#35217 as part of rust-lang#35233 There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information [here](https://gist.github.com/trixnz/ad11e68687529e164427df8f8eb63116). r? @jonathandturner
…turner Update error format for E0062 Fixes rust-lang#35217 as part of rust-lang#35233 There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information [here](https://gist.github.com/trixnz/ad11e68687529e164427df8f8eb63116). r? @jonathandturner
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
|
☔ The latest upstream changes (presumably #35365) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #35217 as part of #35233
There seems to be an issue with the old format ignoring the labels which results in the incorrect line being rendered in the old format. I spoke with @jonathandturner about this and it seems to be a bug. Pertinent information here.
r? @jonathandturner