Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0435, E0437 & E0438 New Error Format #35819

Closed

Conversation

shyamsundarb-arch
Copy link
Contributor

Part of #35801 , #35802 and #35803
r? @jonathandturner

Hi! Please review the changes.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shyamsundarb-arch
Copy link
Contributor Author

@jonathandturner I have committed only file which is Lib.rs, the other commit "Merge remote-tracking branch 'refs/remotes/rust-lang/master'" is automatically getting committed in. Please advice.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 19, 2016

Please update corresponding tests and squash your commits

@sophiajt
Copy link
Contributor

You can read about adding the additional tests in my blog post in the "Extra credit" section.

@shyamsundarb-arch
Copy link
Contributor Author

I went through the document. A small doubt, I could not find the files E0435, E0437 or E0438 under "rust/src/test/compile-fail", can I create files using the example provided in lubrustc_resolve\diagnostics.rs? Please advice.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 20, 2016

They exist: E0435, E0437 and E0438. Update your branch to last rust-lang/master version.

@shyamsundarb-arch
Copy link
Contributor Author

I will create a new pull request with squashed commits.

@shyamsundarb-arch shyamsundarb-arch deleted the NErrFormat branch August 20, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants