Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a -Z flag to guarantee that MIR is generated for all functions #38217

Merged
merged 5 commits into from
Dec 10, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 7, 2016

r? @eddyb

cc @solson

@eddyb
Copy link
Member

eddyb commented Dec 7, 2016

Could this be -Z instead? To avoid it being insta-stable. LGTM otherwise.

@oli-obk oli-obk force-pushed the mir-for-all-and-all-for-mir branch from c21f62a to 87a9ae2 Compare December 7, 2016 12:23
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 7, 2016

done

@eddyb eddyb changed the title add a -C flag to guarantee that MIR is generated for all functions add a -Z flag to guarantee that MIR is generated for all functions Dec 7, 2016
@eddyb
Copy link
Member

eddyb commented Dec 7, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Dec 7, 2016

📌 Commit 87a9ae2 has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Dec 8, 2016

@bors r-

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 9, 2016

This now produces a working compiler (stage2 is building right now) without the flag enabled. It also allows me to compile miri and all its dependencies with the flag enabled (not that there's any point, but I didn't want to wait for an entire compiler to build with the flag enabled). So this is basically working now. I know it has no tests yet. I promise I will write them on monday. Would it be possible to r+ this PR without the tests?

@solson
Copy link
Member

solson commented Dec 9, 2016

I successfully built stage2 with the newest code in this PR and the flag hardcoded to true.

@eddyb
Copy link
Member

eddyb commented Dec 10, 2016

@oli-obk Testing this seems tricky, probably impossible w/o writing a plugin.
@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2016

📌 Commit d74d153 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Dec 10, 2016

⌛ Testing commit d74d153 with merge d53f39e...

bors added a commit that referenced this pull request Dec 10, 2016
add a -Z flag to guarantee that MIR is generated for all functions

r? @eddyb

cc @solson
@bors bors merged commit d74d153 into rust-lang:master Dec 10, 2016
@oli-obk oli-obk deleted the mir-for-all-and-all-for-mir branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants