Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to config.toml #38388

Merged
merged 4 commits into from
Dec 21, 2016
Merged

Add prefix to config.toml #38388

merged 4 commits into from
Dec 21, 2016

Conversation

jackpot51
Copy link
Contributor

This allows rustbuild to be used to install to a prefix.

[build]
prefix = "/path/to/install"

For example, the following config.toml will cause x.py dist --install to install to /path/to/install

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@jackpot51
Copy link
Contributor Author

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Dec 15, 2016
@alexcrichton
Copy link
Member

Thanks! This may actually be a good time to start a new section of config.toml, [install]. I suspect we'll want a whole litany of other options in there eventually as well (aka libdir, etc). With that though sounds good to me.

@jackpot51
Copy link
Contributor Author

@alexcrichton Sounds good.

@@ -70,6 +70,9 @@
# specified, use this rustc binary instead as the stage0 snapshot compiler.
#rustc = "/path/to/bin/rustc"

# Instead of installing installing to /usr/local, install to this path instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"installing installing"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed it

@jackpot51
Copy link
Contributor Author

@alexcrichton I have made the change, adding an [install] section that contains prefix

@alexcrichton
Copy link
Member

Looks good to me! It appears tidy has a problem though?

@jackpot51
Copy link
Contributor Author

I will fix the tidy issue - thanks

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 20, 2016

📌 Commit 228e495 has been approved by alexcrichton

@jackpot51
Copy link
Contributor Author

Thanks @alexcrichton !

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 20, 2016
…crichton

Add prefix to config.toml

This allows `rustbuild` to be used to install to a prefix.
```toml
[build]
prefix = "/path/to/install"
```
For example, the following `config.toml` will cause `x.py dist --install` to install to `/path/to/install`
bors added a commit that referenced this pull request Dec 20, 2016
@bors bors merged commit 228e495 into rust-lang:master Dec 21, 2016
@jackpot51 jackpot51 deleted the config_toml_prefix branch December 21, 2016 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants