Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pretty printing of unions in debuggers #38753

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Add pretty printing of unions in debuggers #38753

merged 1 commit into from
Jan 1, 2017

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Jan 1, 2017

Fixes #37479

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -9,7 +9,6 @@
// except according to those terms.

// min-lldb-version: 310
// ignore-macos FIXME(#37479)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that while I think this should be fixed for macos, I've only tested for linux with llvm 3.9.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 1, 2017

📌 Commit 1765a3f has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Jan 1, 2017

⌛ Testing commit 1765a3f with merge 7b659cf...

bors added a commit that referenced this pull request Jan 1, 2017
Add pretty printing of unions in debuggers

Fixes #37479
@bors
Copy link
Contributor

bors commented Jan 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 7b659cf to master...

@bors bors merged commit 1765a3f into rust-lang:master Jan 1, 2017
@philipc philipc deleted the debuginfo-union branch January 3, 2017 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants