travis: Enable testing i686 musl #39227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
nagisa
reviewed
Jan 22, 2017
| // The unwinder used by i686-unknown-linux-musl, the LLVM libunwind | ||
| // implementation, apparently relies on frame pointers existing... somehow. | ||
| // It's not clear to me why nor where this dependency is introduced, but the | ||
| // test suite doesn't pass with frame pointers eliminated and it passes with |
There was a problem hiding this comment.
This sentence contradicts itself by saying test passes and does not pass when the same condition applies.
This fixes the final issues with the target related to unwinding by disabling removal of frame pointers.
alexcrichton
force-pushed
the
enable-i686-musl
branch
from
d4f0cf5 to
d56999a
Compare
|
@bors r+ |
|
📌 Commit d56999a has been approved by |
bors
added a commit
that referenced
this pull request
Jan 24, 2017
travis: Enable testing i686 musl This fixes the final issues with the target related to unwinding by disabling removal of frame pointers.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the final issues with the target related to unwinding by disabling
removal of frame pointers.