Rollup of 12 pull requests #39869
Closed
Rollup of 12 pull requests #39869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Feb 16, 2017
frewsxcv
commented
- Successful merges: Stabilize field init shorthand #39761, book: don’t use GNU extensions in the example unnecessarily #39775, Allow more Cell methods for non-Copy types #39793, Add a test that -fPIC is applied #39803, Show five traits implementation in help when there are exactly five #39804, static recursion test added to compile-fail test suite #39834, rustc: Link statically to the MSVCRT #39837, make doc consistent with var name #39839, Update procedural-macros.md #39840, sys/mod doc update and mod import order adjust #39844, Fix typo #39846, Fix parameter to GetUserProfileDirectoryW #39861
- Failed merges:
Contributes to rust-lang#39264
Contributes to rust-lang#39264
This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
Fix typo
The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro.
Stabilize field init shorthand Closes rust-lang#37340. ~Still blocked by the documentation issue rust-lang#38830.~ EDIT: seems that all parts required for stabilisation are fixed, so its not blocked.
book: don’t use GNU extensions in the example unnecessarily The use of a GNU C extension for bloc expressions is immaterial to the actual problem with C macros that the section tries to show so don’t use it and instead use a plain C way of writing the macro which has added benefit of being better C code (since the macro now behaves like a function, syntax-wise).
Allow more Cell methods for non-Copy types Clearly, `get_mut` is safe for any `T`. The other two only provide unsafe pointers anyway. The only remaining inherent method with `Copy` bound is `get`, which sounds about right to me. I found the order if `impl` blocks in the file a little weird (first inherent impl, then some trait impls, then another inherent impl), but didn't change it to keep the diff small. Contributes to rust-lang#39264
Add a test that -fPIC is applied r? @alexcrichton Can it really be this simple? I've tested it works, but still testing that it used to fail.
…jonathandturner Show five traits implementation in help when there are exactly five Fixes rust-lang#39802
…n, r=est31 static recursion test added to compile-fail test suite Issue rust-lang#39059 r? @est31
rustc: Link statically to the MSVCRT This commit changes all MSVC rustc binaries to be compiled with `-C target-feature=+crt-static` to link statically against the MSVCRT instead of dynamically (as it does today). This also necessitates compiling LLVM in a different fashion, ensuring it's compiled with `/MT` instead of `/MD`. cc rust-lang#37406
make doc consistent with var name
Update procedural-macros.md Fix typo
sys/mod doc update and mod import order adjust * Some doc updates. * Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.
Fix parameter to GetUserProfileDirectoryW
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 6343542 has been approved by |
|
⌛ Testing commit 6343542 with merge 94a093d... |
|
💔 Test failed - status-travis |
|
@bors retry |
|
⌛ Testing commit 6343542 with merge bf044c3... |
|
💔 Test failed - status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.